aws_mwaaserverless_workflow: Add code argument - #49929
Draft
astanfel wants to merge 7 commits into
Draft
Conversation
Adds the aws_mwaaserverless_workflow resource for Amazon MWAA Serverless, covering create/read/update/delete, transparent tagging, ARN-based resource identity, and acceptance/identity/tags tests. Closes hashicorp#45254
Adds the optional code block (Smithy union types.Code / CodeMemberS3Location) via a flex.Expander/Flattener on codeModel, wires it into the update path, and adds acceptance test + documentation coverage.
Contributor
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
MWAA Serverless workflows are created/updated synchronously (no CREATING state, no API waiter), so reduce create/update timeouts (30m was carried over from MWAA environments) and document the synchronous behavior. Also correct the documented workflow ARN format to workflow/<name>-<suffix>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #49927. Adds the optional
codeargument toaws_mwaaserverless_workflow, which was deliberately deferred from the initial resource PR because it maps to a Smithy tagged union (types.Code/CodeMemberS3Location).codeis modeled as a nested block containing ans3_locationblock (the sole current union member), using the provider's standard union pattern — aflex.Expander/flex.Flattenerimplemented oncodeModel. It is wired into the update path (theUpdateWorkflowAPI acceptsCode, so it is updatable in place) and covered by a new acceptance test (TestAccMWAAServerlessWorkflow_code) and documentation.This branch is stacked on the branch for #49927 (which introduces the resource itself). Until #49927 merges, the diff below includes those commits. Once #49927 is merged, this branch will be rebased onto
mainand the diff will reduce to just thecodesupport. Opening as a draft for early visibility; it should be reviewed after #49927.Relations
Relates to #45254
Depends on #49927
Output from Acceptance Testing
Acceptance tests require a live account with MWAA Serverless access and are not run in this environment. The package builds, vets, and links cleanly.