Skip to content

Add EBS volume copy encryption and sharing support - #49933

Open
ElijahQuinones wants to merge 1 commit into
hashicorp:mainfrom
ElijahQuinones:main
Open

Add EBS volume copy encryption and sharing support#49933
ElijahQuinones wants to merge 1 commit into
hashicorp:mainfrom
ElijahQuinones:main

Conversation

@ElijahQuinones

Copy link
Copy Markdown

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Adds additional encryption options for Volume Clones.

Description

This changes adds the new volume clones encryption parameters as well as cross account clones and volume sharing.

Relations

N/A

References

New AWS docs regarding this change https://aws.amazon.com/about-aws/whats-new/2026/09/ebs-volume-clones-cross-account-copy/

Output from Acceptance Testing

% make testacc TESTS='TestAccEC2(EBSVolumeCopy_|EBSVolumeDataSource_basic$)' PKG=ec2                                                                                        
..w.
  AWS_PROFILE=*redacted* \                                                                                                                                                                            
  AWS_ALTERNATE_PROFILE=*redacted* \
  AWS_DEFAULT_REGION=us-west-2 \
  make testacc TESTS='TestAccEC2(EBSVolumeCopy_|EBSVolumeDataSource_basic)' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Validating schemas
ok      github.com/hashicorp/terraform-provider-aws/internal/provider/sdkv2     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/provider/framework (cached)
make: Running acceptance tests on branch: 🌿 main 🌿...
TF_ACC=1 go1.26.6 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2(EBSVolumeCopy_|EBSVolumeDataSource_basic)'  -timeout 360m -vet=off -buildvcs=false
2026/09/10 00:06:26 Creating Terraform AWS Provider (SDKv2-style)...
2026/09/10 00:06:26 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccEC2EBSVolumeCopy_basic
=== PAUSE TestAccEC2EBSVolumeCopy_basic
=== RUN   TestAccEC2EBSVolumeCopy_kmsKeyAlias
=== PAUSE TestAccEC2EBSVolumeCopy_kmsKeyAlias
=== RUN   TestAccEC2EBSVolumeCopy_shared
=== PAUSE TestAccEC2EBSVolumeCopy_shared
=== RUN   TestAccEC2EBSVolumeCopy_disappears
=== PAUSE TestAccEC2EBSVolumeCopy_disappears
=== RUN   TestAccEC2EBSVolumeCopy_updateSize
=== PAUSE TestAccEC2EBSVolumeCopy_updateSize
=== RUN   TestAccEC2EBSVolumeCopy_updateIops
=== PAUSE TestAccEC2EBSVolumeCopy_updateIops
=== RUN   TestAccEC2EBSVolumeCopy_updateThroughput
=== PAUSE TestAccEC2EBSVolumeCopy_updateThroughput
=== RUN   TestAccEC2EBSVolumeCopy_updateVolumeType
=== PAUSE TestAccEC2EBSVolumeCopy_updateVolumeType
=== RUN   TestAccEC2EBSVolumeCopy_tags
=== PAUSE TestAccEC2EBSVolumeCopy_tags
=== RUN   TestAccEC2EBSVolumeCopy_invalidConfiguration
=== PAUSE TestAccEC2EBSVolumeCopy_invalidConfiguration
=== RUN   TestAccEC2EBSVolumeDataSource_basic
=== PAUSE TestAccEC2EBSVolumeDataSource_basic
=== CONT  TestAccEC2EBSVolumeCopy_basic
=== CONT  TestAccEC2EBSVolumeCopy_updateThroughput
=== CONT  TestAccEC2EBSVolumeCopy_tags
=== CONT  TestAccEC2EBSVolumeCopy_updateSize
=== CONT  TestAccEC2EBSVolumeCopy_updateVolumeType
=== CONT  TestAccEC2EBSVolumeCopy_kmsKeyAlias
=== CONT  TestAccEC2EBSVolumeCopy_invalidConfiguration
=== CONT  TestAccEC2EBSVolumeCopy_disappears
=== CONT  TestAccEC2EBSVolumeCopy_updateIops
=== CONT  TestAccEC2EBSVolumeCopy_shared
=== CONT  TestAccEC2EBSVolumeDataSource_basic
--- PASS: TestAccEC2EBSVolumeCopy_invalidConfiguration (15.29s)
--- PASS: TestAccEC2EBSVolumeDataSource_basic (58.24s)
--- PASS: TestAccEC2EBSVolumeCopy_kmsKeyAlias (86.86s)
--- PASS: TestAccEC2EBSVolumeCopy_disappears (90.33s)
--- PASS: TestAccEC2EBSVolumeCopy_shared (118.43s)
--- PASS: TestAccEC2EBSVolumeCopy_updateSize (137.12s)
--- PASS: TestAccEC2EBSVolumeCopy_updateIops (137.22s)
--- PASS: TestAccEC2EBSVolumeCopy_updateVolumeType (137.57s)
--- PASS: TestAccEC2EBSVolumeCopy_updateThroughput (137.65s)
--- PASS: TestAccEC2EBSVolumeCopy_basic (143.05s)
--- PASS: TestAccEC2EBSVolumeCopy_tags (145.91s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        146.194s

@ElijahQuinones
ElijahQuinones requested a review from a team as a code owner September 10, 2026 00:12
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Our automation has detected the following potential issues with your pull request


❌ Dependency Changes (Click to expand)

Typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. For more information, see the Dependency Updates section of the contributing guide.

Remove any changes to the go.mod or go.sum files and commit them into this pull request to prevent delays with reviewing and potentially merging it.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Adding a New AWS Service section of the contributing guide, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.
❌ Changelog Entry Required (Click to expand)

The proposed change requires a changelog entry. Please see the Changelog Process section of the contributing guide for information on the changelog generation process.

Tip: This check is not triggered for draft pull requests, since the pull request number is not known until the pull request is opened and is required to create a changelog entry. Opening a pull request first as a draft, adding the requisite changelog entry file, and then marking the pull request as ready for review will prevent future warnings.

@github-actions

Copy link
Copy Markdown
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. size/XL Managed by automation to categorize the size of a PR. labels Sep 10, 2026
@ElijahQuinones

Copy link
Copy Markdown
Author

⚠️ Our automation has detected the following potential issues with your pull request

❌ Dependency Changes (Click to expand)

Typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. For more information, see the Dependency Updates section of the contributing guide.

Remove any changes to the go.mod or go.sum files and commit them into this pull request to prevent delays with reviewing and potentially merging it.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Adding a New AWS Service section of the contributing guide, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

❌ Changelog Entry Required (Click to expand)

Needed to bump the deps for new go sdk can revert and rebase once dependabot puts those deps into main

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants