Skip to content

r/aws_mailmanager_ingress_point: Add status_to_update argument - #49954

Draft
taruntej-a wants to merge 11 commits into
mainfrom
b-aws_mailmanager_ingress_point-status
Draft

r/aws_mailmanager_ingress_point: Add status_to_update argument#49954
taruntej-a wants to merge 11 commits into
mainfrom
b-aws_mailmanager_ingress_point-status

Conversation

@taruntej-a

@taruntej-a taruntej-a commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

aws_mailmanager_ingress_point: Add status_to_update argument

Relations

Closes #49609

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@taruntej-a taruntej-a self-assigned this Sep 11, 2026
@taruntej-a taruntej-a added the rnd-ind-provider rnd-ind-provider label Sep 11, 2026
@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/mailmanager Issues and PRs that pertain to the mailmanager service. size/M Managed by automation to categorize the size of a PR. and removed prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 11, 2026
@taruntej-a
taruntej-a requested a balanced review from Copilot September 11, 2026 01:32
@taruntej-a

taruntej-a commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

/test

@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Automated tests have been triggered for package mailmanager. Results will be posted when complete.

Copilot AI reviewed Sep 11, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Initial creation ignores CLOSED, and update polling can fail on the previous stable status.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds status_to_update support for managing Mail Manager ingress point activation state.

Changes:

  • Adds the new schema argument and status-aware update waiter.
  • Adds acceptance coverage for closing and reactivating ingress points.
  • Updates documentation and changelog.
File summaries
File Description
.changelog/49954.txt Records the enhancement.
internal/service/mailmanager/ingress_point.go Implements status updates and waiter behavior.
internal/service/mailmanager/ingress_point_test.go Tests status transitions.
internal/service/mailmanager/mailmanager_test.go Registers the new serial test.
website/docs/r/mailmanager_ingress_point.html.markdown Documents the argument.
Review details

Suppressed comments (1)

internal/service/mailmanager/ingress_point.go:460

  • 🤖 This Copilot comment is not a required action for the contributor.

The update waiter rejects the pre-update stable state. Immediately after UpdateIngressPoint returns, an eventually consistent read can still report ACTIVE while targeting CLOSED (or CLOSED while targeting ACTIVE); because neither is pending, StateChangeConf returns UnexpectedStateError instead of continuing to poll. Include the prior stable state in Pending for update waits (without overlapping the target), or use a dedicated update waiter that does so.

		Pending: enum.Slice(
			awstypes.IngressPointStatusProvisioning,
			awstypes.IngressPointStatusUpdating,
		),
  • Files reviewed: 5/5 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread internal/service/mailmanager/ingress_point.go
@taruntej-a
taruntej-a requested a balanced review from Copilot September 11, 2026 02:44
@taruntej-a

taruntej-a commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

/test

Copilot AI reviewed Sep 11, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The waiter can fail during normal asynchronous status transitions, and the create-time closed path lacks coverage.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment thread internal/service/mailmanager/ingress_point.go
Comment thread internal/service/mailmanager/ingress_point_test.go Outdated
@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Automated tests have been triggered for package mailmanager. Results will be posted when complete.

@github-actions github-actions Bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Sep 11, 2026
@hc-github-team-terraform-aws

hc-github-team-terraform-aws commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Latest automated test results:

% TF_ACC=1 go test './internal/service/mailmanager/...' -count=1 -json -v -run='(TestAccMailManager_)' -parallel '20' -timeout=0 -vet=off -buildvcs=false

TestAccMailManager_serial: [SKIP] 4467.658s
TestAccMailManager_serial/Archive: [SKIP] 4467.612s
<unknown test name>: [PASS] 36.7s
<unknown test name>: [PASS] 33.14s
<unknown test name>: [PASS] 59.61s
<unknown test name>: [PASS] 61.37s
TestAccMailManager_serial/Archive/Identity: [PASS] 119.27s
TestAccMailManager_serial/Archive/Identity/basic: [PASS] 59.94s
TestAccMailManager_serial/Archive/Identity/RegionOverride: [PASS] 59.33s
<unknown test name>: [SKIP] 4157.537s
<unknown test name>: [SKIP] 4157.517s
<unknown test name>: [SKIP] 4157.516s
<unknown test name>: [PASS] 108.7s
<unknown test name>: [PASS] 67.79s
    [... truncated ...]
TestAccMailManager_serial/IngressPoint/Tags/DefaultTags_updateToResourceOnly: [PASS] 104.94s
TestAccMailManager_serial/IngressPoint/Tags/ComputedTag_OnUpdate_Replace: [PASS] 106.18s
TestAccMailManager_serial/IngressPoint/Tags/null: [SKIP] 439.319s
TestAccMailManager_serial/IngressPoint/Tags/ComputedTag_OnCreate: [PASS] 81.34s
TestAccMailManager_serial/IngressPoint/List: [PASS] 200.94s
TestAccMailManager_serial/IngressPoint/List/basic: [PASS] 65.63s
TestAccMailManager_serial/IngressPoint/List/includeResource: [PASS] 66.97s
TestAccMailManager_serial/IngressPoint/List/regionOverride: [PASS] 68.35s
TestAccMailManager_serial/IngressPoint/basic: [PASS] 59.08s
TestAccMailManager_serial/IngressPoint/disappears: [PASS] 53.86s
TestAccMailManager_serial/Relay: [PASS] 44.03s
TestAccMailManager_serial/Relay/Authentication_secretARN: [PASS] 44.03s

@hc-github-team-terraform-aws

hc-github-team-terraform-aws commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Latest automated test results:

% TF_ACC=1 go test './internal/service/mailmanager/...' -count=1 -json -v -run='(TestAccMailManager_)' -parallel '20' -timeout=0 -vet=off -buildvcs=false

TestAccMailManager_serial: [SKIP] 4114.56s
TestAccMailManager_serial/Archive: [SKIP] 4114.511s
TestAccMailManager_serial/Archive/Identity: [PASS] 108.83s
TestAccMailManager_serial/Archive/Identity/RegionOverride: [PASS] 55.21s
TestAccMailManager_serial/Archive/Identity/basic: [PASS] 53.62s
TestAccMailManager_serial/Archive/Tags: [SKIP] 4005.685s
TestAccMailManager_serial/Archive/Tags/basic: [PASS] 127.16s
TestAccMailManager_serial/Archive/Tags/EmptyTag_OnUpdate_Replace: [SKIP] 3878.503s
TestAccMailManager_serial/Archive/Tags/DefaultTags_providerOnly: [PASS] 128.52s
TestAccMailManager_serial/Archive/Tags/DefaultTags_overlapping: [PASS] 98.85s
TestAccMailManager_serial/Archive/Tags/DefaultTags_updateToResourceOnly: [PASS] 58.49s
TestAccMailManager_serial/Archive/Tags/DefaultTags_emptyResourceTag: [SKIP] 3592.656s
TestAccMailManager_serial/Archive/Tags/ComputedTag_OnUpdate_Add: [PASS] 63.38s
TestAccMailManager_serial/Archive/Tags/EmptyMap: [PASS] 37.09s
TestAccMailManager_serial/Archive/Tags/EmptyTag_OnCreate: [SKIP] 3492.19s
TestAccMailManager_serial/Archive/Tags/EmptyTag_OnUpdate_Add: [SKIP] 3492.191s
TestAccMailManager_serial/Archive/Tags/DefaultTags_nonOverlapping: [PASS] 98.43s
TestAccMailManager_serial/Archive/Tags/DefaultTags_nullNonOverlappingResourceTag: [SKIP] 3393.759s
TestAccMailManager_serial/Archive/Tags/IgnoreTags_Overlap_DefaultTag: [PASS] 76.33s
TestAccMailManager_serial/Archive/Tags/AddOnUpdate: [PASS] 60.55s
TestAccMailManager_serial/Archive/Tags/ComputedTag_OnCreate: [PASS] 40.28s
TestAccMailManager_serial/Archive/Tags/ComputedTag_OnUpdate_Replace: [PASS] 63.29s
TestAccMailManager_serial/Archive/Tags/null: [SKIP] 3153.31s
TestAccMailManager_serial/Archive/Tags/DefaultTags_updateToProviderOnly: [PASS] 61.05s
TestAccMailManager_serial/Archive/Tags/DefaultTags_nullOverlappingResourceTag: [SKIP] 3092.261s
TestAccMailManager_serial/Archive/Tags/IgnoreTags_Overlap_ResourceTag: [PASS] 85.27s
TestAccMailManager_serial/Archive/List: [PASS] 0s
TestAccMailManager_serial/Archive/List/basic: [PASS] 48.51s
TestAccMailManager_serial/Archive/List/includeResource: [PASS] 47.22s
TestAccMailManager_serial/Archive/List/regionOverride: [PASS] 48.99s
TestAccMailManager_serial/Archive/basic: [PASS] 32.83s
TestAccMailManager_serial/Archive/disappears: [PASS] 30.59s
TestAccMailManager_serial/Archive/update: [PASS] 54.21s
TestAccMailManager_serial/Archive/retention: [PASS] 54.05s
TestAccMailManager_serial/IngressPoint: [SKIP] 2786.351s
TestAccMailManager_serial/IngressPoint/type: [PASS] 87.53s
TestAccMailManager_serial/IngressPoint/networkConfiguration_public: [PASS] 115.7s
TestAccMailManager_serial/IngressPoint/networkConfiguration_private: [PASS] 151.4s
TestAccMailManager_serial/IngressPoint/ingressPointConfiguration_tlsAuth: [PASS] 85.65s
TestAccMailManager_serial/IngressPoint/disappears: [PASS] 62.02s
TestAccMailManager_serial/IngressPoint/ingressPointConfiguration_smtpPasswordWO: [PASS] 56.67s
TestAccMailManager_serial/IngressPoint/Identity: [PASS] 177.26s
TestAccMailManager_serial/IngressPoint/Identity/basic: [PASS] 88.38s
TestAccMailManager_serial/IngressPoint/Identity/RegionOverride: [PASS] 88.88s
TestAccMailManager_serial/IngressPoint/Tags: [SKIP] 2050.106s
TestAccMailManager_serial/IngressPoint/Tags/DefaultTags_nullNonOverlappingResourceTag: [SKIP] 2050.087s
TestAccMailManager_serial/IngressPoint/Tags/ComputedTag_OnUpdate_Add: [PASS] 98.16s
TestAccMailManager_serial/IngressPoint/Tags/IgnoreTags_Overlap_DefaultTag: [PASS] 113.54s
TestAccMailManager_serial/IngressPoint/Tags/EmptyMap: [PASS] 71.14s
TestAccMailManager_serial/IngressPoint/Tags/AddOnUpdate: [PASS] 95.34s
TestAccMailManager_serial/IngressPoint/Tags/DefaultTags_updateToProviderOnly: [PASS] 95.59s
TestAccMailManager_serial/IngressPoint/Tags/EmptyTag_OnCreate: [SKIP] 1576.318s
TestAccMailManager_serial/IngressPoint/Tags/EmptyTag_OnUpdate_Add: [SKIP] 1576.318s
TestAccMailManager_serial/IngressPoint/Tags/DefaultTags_providerOnly: [PASS] 167.2s
TestAccMailManager_serial/IngressPoint/Tags/DefaultTags_nonOverlapping: [PASS] 134.96s
TestAccMailManager_serial/IngressPoint/Tags/DefaultTags_overlapping: [PASS] 134.8s
TestAccMailManager_serial/IngressPoint/Tags/IgnoreTags_Overlap_ResourceTag: [PASS] 123.95s
TestAccMailManager_serial/IngressPoint/Tags/EmptyTag_OnUpdate_Replace: [SKIP] 1015.404s
TestAccMailManager_serial/IngressPoint/Tags/DefaultTags_updateToResourceOnly: [PASS] 96.19s
TestAccMailManager_serial/IngressPoint/Tags/DefaultTags_emptyResourceTag: [SKIP] 919.215s
TestAccMailManager_serial/IngressPoint/Tags/DefaultTags_nullOverlappingResourceTag: [SKIP] 919.214s
TestAccMailManager_serial/IngressPoint/Tags/ComputedTag_OnCreate: [PASS] 60.22s
TestAccMailManager_serial/IngressPoint/Tags/ComputedTag_OnUpdate_Replace: [PASS] 98.28s
TestAccMailManager_serial/IngressPoint/Tags/basic: [PASS] 166.07s
TestAccMailManager_serial/IngressPoint/Tags/null: [SKIP] 594.654s
TestAccMailManager_serial/IngressPoint/List: [PASS] 188.86s
TestAccMailManager_serial/IngressPoint/List/basic: [PASS] 62.5s
TestAccMailManager_serial/IngressPoint/List/includeResource: [PASS] 62.64s
TestAccMailManager_serial/IngressPoint/List/regionOverride: [PASS] 63.71s
TestAccMailManager_serial/IngressPoint/basic: [PASS] 66.71s
TestAccMailManager_serial/IngressPoint/update: [PASS] 76.12s
TestAccMailManager_serial/IngressPoint/statusToUpdate: [PASS] 133.26s
TestAccMailManager_serial/IngressPoint/tlsPolicy: [PASS] 90.02s
TestAccMailManager_serial/Relay: [PASS] 39.62s
TestAccMailManager_serial/Relay/Authentication_secretARN: [PASS] 39.62s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@taruntej-a taruntej-a

Labels

documentation Introduces or discusses updates to documentation. rnd-ind-provider rnd-ind-provider service/mailmanager Issues and PRs that pertain to the mailmanager service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws_mailmanager_ingress_point does not support updating status (ACTIVE/DEACTIVATED)

3 participants

@taruntej-a @hc-github-team-terraform-aws