Skip to content

Conversation

@jackofallops
Copy link
Member

@jackofallops jackofallops commented Jan 16, 2025

This PR introduces a Group resource that omits management and exposure of group members. This resource is intended for use cases where a Group needs to be managed via terraform, but the members of the group are not of concern, typically where the members list is sufficiently large that performance problems are encountered, and/or members are managed by other means.

closes #954 - Since there is no current way to improve the linear performance problem with the List() call, the azuread_group resource cannot be changed to satisfy a performance improvement.

@katbyte
Copy link
Collaborator

katbyte commented Jan 30, 2025

this might fix #954

@Andrei-Predoiu
Copy link

This is something we really need. We don't set members inside the azuread_group resource but the provider still tries to read all the members.

@jackofallops jackofallops force-pushed the f/new-resource-group-without-members branch from 78ce053 to 4d33d43 Compare March 20, 2025 12:47
@jackofallops jackofallops force-pushed the f/new-resource-group-without-members branch from 4d33d43 to 77613a3 Compare March 20, 2025 14:12
@jackofallops jackofallops marked this pull request as ready for review March 20, 2025 17:58
@jackofallops jackofallops requested a review from a team as a code owner March 20, 2025 17:58
@jackofallops
Copy link
Member Author

as per azuread_group some tests are failing due to a required change on the underlying CI server image.

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍰

@jackofallops jackofallops merged commit f890d84 into main Mar 21, 2025
25 checks passed
@jackofallops jackofallops deleted the f/new-resource-group-without-members branch March 21, 2025 06:39
jackofallops added a commit that referenced this pull request Mar 21, 2025
jackofallops added a commit that referenced this pull request Mar 21, 2025
* Update CHANGELOG.md for #1664 #1567

* Update CHANGELOG.md for #1666

* Update CHANGELOG.md for #1635

* Update CHANGELOG.md for #1623

* prep for release

---------

Co-authored-by: Wyatt Fry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Group Resource CRUD slowdown on large member diff

3 participants