-
Notifications
You must be signed in to change notification settings - Fork 329
fix(docs): correct resource IDs for importing delegated permissions and claims mapping policy #1648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nd claims mapping policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nbaju1 - Just one change to take a look at if you could.
|
@jackofallops did you get a chance to review the change? |
|
Thanks for updating the docs - I ran into the error today when trying to import a azuread_synchronization_job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR @nbaju1, I've left 2 minor comments inline
docs/resources/service_principal_claims_mapping_policy_assignment.md
Outdated
Show resolved
Hide resolved
Co-authored-by: sreallymatt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nbaju1, LGTM! ✅
azuread_claims_mapping_policyazuread_service_principal_delegated_permission_grantazuread_synchronization_jobWill fix #1647, #1652 and #1658.