Add object_id to named_location

[alexwilcox9]

In the previous major version of the provider the following Terraform would work

terraform {
  required_providers {
    azuread = {
      source  = "hashicorp/azuread"
      version = "~> 2.0"
    }
  }
}


resource "azuread_conditional_access_policy" "example" {
  display_name = "example policy"
  state        = "disabled"

  conditions {
    client_app_types = ["all"]

    applications {
      included_applications = ["All"]
    }

    locations {
      included_locations = ["All"]
      excluded_locations = [azuread_named_location.example.id]
    }

    users {
      included_users = ["All"]
    }
  }

  grant_controls {
    operator          = "OR"
    built_in_controls = ["block"]
  }

}

resource "azuread_named_location" "example" {
  display_name = "example"
  ip {
    ip_ranges = ["8.8.8.8/32"]
  }
}

However in the current version an error is produced due to the change in the id attribute and the following error is produced

╷
│ Error: Could not create conditional access policy
│ 
│   with azuread_conditional_access_policy.example,
│   on main.tf line 11, in resource "azuread_conditional_access_policy" "example":
│   11: resource "azuread_conditional_access_policy" "example" {
│ 
│ unexpected status 400 (400 Bad Request) with error: BadRequest: 1040: NamedLocation with id /identity/conditionalAccess/namedLocations/0c5924be-4bae-48ab-9245-ecbd46e3ee50 does
│ not exist in the directory.
╵

It is of course possible to get the correct value with split but this doesn't feel very elegant

      excluded_locations = [split("/", azuread_named_location.example.id)[4]]

This PR adds the object_id to the azuread_named_location resource and data source using the ID returned from the graph API

It might be worth adding a new test on the azuread_conditional_access_policy resource that uses a named location - let me know if you'd like this added

Fixes: #1504

[sreallymatt]

Thanks for adding this @alexwilcox9, this LGTM but could you add a test for this regression as well?

[alexwilcox9]

Hey @sreallymatt

I've removed that extra asterisk and added a test that creates a conditional access policy that consumes a named location

[sreallymatt]

Thanks @alexwilcox9 LGTM ✅