Skip to content

Conversation

@Threpio
Copy link
Contributor

@Threpio Threpio commented Oct 27, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This new flag allows for the prevention of DDoS attacking Azure and being rate-limited once a group of users reaches a critical mass by preventing the population of the members array in the azuread_group datasource.

A new flag of include_members (that defaults to true to maintain current functionality) allows for a check to be carried out when the member list is fetched and poulated and prevents it if it is faulse.

Changes to existing Resource / Data Source

  • [ x ] I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • [ x ] I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • [ x ] I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • [ x ] My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azuread_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • [ x ] Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • [ x ] Enhancement
  • Breaking Change

Related Issue(s)

Fixes #862 - Does not fix this as it does not affect the resource but resolves some of the issues.

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

azuread_group refresh takes very long and causes high cpu (if group has many members)

1 participant