`azurerm_shared_image_version` - support for new block `uefi_settings` by yeoldegrove · Pull Request #28076 · hashicorp/terraform-provider-azurerm

yeoldegrove · 2024-11-20T14:17:20Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Bump galleryimageversions API to support security profile and uefi settings.
For resource shared_image_version
- support new block uefi_settings
  - This new settings configure secure boot certificates and is needed if you want to boot a secure bootable image with custom keys.
- add documentation for uefi_settings
Not adding a matching block to the data source as the Azure API does not return any security profiles.

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

shared_image_version - support for new block uefi_settings [https://github.com/azurerm_shared_image_version - support for new block uefi_settings #28076]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #28064

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

yeoldegrove · 2024-12-04T09:51:25Z

When can I expect that somebody has a look at this?

github-actions · 2025-01-20T06:03:45Z

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

yeoldegrove · 2025-02-04T10:27:16Z

It would be great if somebody would take a look at this.

codgician · 2025-02-04T11:26:40Z

Kindly adding some active maintainers for comments: @katbyte @jackofallops @stephybun

yeoldegrove · 2025-02-17T06:33:43Z

@codgician @katbyte @jackofallops @stephybun Can anybody please start reviewing this?

ms-zhenhua

Hi @yeoldegrove,

Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

yeoldegrove · 2025-02-24T11:49:46Z

@ms-zhenhua Thanks for the review! I just fixed all the issues you pointed out and force pushed to this PR.

ms-zhenhua

Hi @yeoldegrove,

Thanks for your updates - I've taken another look through and left some comments inline. Please help confirm.

yeoldegrove · 2025-02-26T12:47:12Z

@ms-zhenhua another round of improvements ;)

ms-zhenhua

Hi @yeoldegrove,

Thanks for your updates - I've taken another look through and left some comments inline. Please help confirm.

catriona-m

Hi @yeoldegrove it looks like there are some CI failures on this. Could you take a look at fixing this up and then I can take another look? Thanks!

yeoldegrove · 2025-10-27T13:18:18Z

@catriona-m make test now works for me if I run it locally.

…settings tests

…ate_base64

…nal_signatures

yeoldegrove · 2025-11-11T14:47:21Z

@catriona-m Could you have another look?

yeoldegrove · 2025-12-01T11:38:27Z

@catriona-m Could you have another look?

This PR just had it's 1st anniversary by the way ;)

yeoldegrove · 2026-01-13T12:40:41Z

Happy New Year. Pinging this again. In case anything is still required from my side, please say so.

yeoldegrove · 2026-02-02T09:20:48Z

A new month, a new ping. @catriona-m Anything needed from my side to get this merged?

yeoldegrove · 2026-04-09T06:38:32Z

Two month later, a new ping. @catriona-m Anything needed from my side to get this merged?

…azurerm into shared_image_version_uefi_settings

wuxu92

Thanks for contributing this resource! I left some comments about the force new logic and validation, otherwise looks good to me.

…ngs`

yeoldegrove · 2026-04-10T08:40:01Z

@wuxu92 Thanks for the review. Addressed both of your comments.

wuxu92 · 2026-04-13T06:47:06Z

+
+The `uefi_settings` block supports the following:
+
+* `signature_template_names` - (Required) A list of UEFI signature template names to include in the UEFI settings. Possible values are `MicrosoftUefiCertificateAuthorityTemplate`, `MicrosoftWindowsTemplate` and `NoSignatureTemplate`


Thanks for the update! we need to update the document for the ForceNew logic of these fields. otherwise looks good to me!

@wuxu92 Updated the docs, too.

wuxu92

LGTM, but can we remove this comment line?

yeoldegrove requested a review from a team as a code owner November 20, 2024 14:17

github-actions bot added enhancement documentation dependencies size/XL labels Nov 20, 2024

yeoldegrove mentioned this pull request Nov 20, 2024

opentofu/terraform resources for secure bootable images on Azure gardenlinux/gardenlinux#2490

Open

github-actions bot added the waiting-response label Dec 20, 2024

github-actions bot added stale and removed waiting-response labels Jan 20, 2025

yeoldegrove force-pushed the shared_image_version_uefi_settings branch from 5cde4dd to 58ad4cf Compare January 20, 2025 10:40

yeoldegrove mentioned this pull request Feb 4, 2025

Support for uefi_settings in azurerm_shared_image_version #28064

Open

1 task

github-actions bot removed the stale label Feb 4, 2025

ms-zhenhua suggested changes Feb 21, 2025

View reviewed changes

ms-zhenhua reviewed Feb 21, 2025

View reviewed changes

Comment thread website/docs/r/shared_image_version.html.markdown Outdated

ms-zhenhua reviewed Feb 21, 2025

View reviewed changes

Comment thread website/docs/r/shared_image_version.html.markdown Outdated

ms-zhenhua reviewed Feb 21, 2025

View reviewed changes

Comment thread website/docs/r/shared_image_version.html.markdown Outdated

ms-zhenhua reviewed Feb 21, 2025

View reviewed changes

Comment thread website/docs/r/shared_image_version.html.markdown Outdated

yeoldegrove force-pushed the shared_image_version_uefi_settings branch from 58ad4cf to 57ef77c Compare February 24, 2025 11:46

yeoldegrove requested a review from ms-zhenhua February 24, 2025 11:49

ms-zhenhua suggested changes Feb 26, 2025

View reviewed changes

yeoldegrove force-pushed the shared_image_version_uefi_settings branch from 57ef77c to d74f0fc Compare February 26, 2025 12:45

ms-zhenhua suggested changes Feb 27, 2025

View reviewed changes

yeoldegrove force-pushed the shared_image_version_uefi_settings branch from d74f0fc to f6624ce Compare March 5, 2025 12:57

catriona-m requested changes Oct 23, 2025

View reviewed changes

yeoldegrove force-pushed the shared_image_version_uefi_settings branch from cf82c0c to 3fae953 Compare October 27, 2025 09:46

github-actions bot removed the waiting-response label Oct 27, 2025

yeoldegrove requested a review from catriona-m October 27, 2025 13:18

yeoldegrove added 7 commits October 28, 2025 15:08

shared_image_version_resource - set trusted_launch_supported in uefi_…

988dfae

…settings tests

shared_image_version_resource - return all list values for certific…

317a68f

…ate_base64

shared_image_version_resource - move uefiKeySchema() to shared_schema

c8e6b74

shared_image_version_resource - pass any db, dbx, kek, pk to addito…

9da880a

…nal_signatures

shared_image_version_resource - expanded keys always have values

670cedc

shared_image_version_resource - do not check for nil on pointer.From

2524c4f

shared_image_version_resource - move certificate to testdata

3b5fda2

yeoldegrove force-pushed the shared_image_version_uefi_settings branch from 3fae953 to 3b5fda2 Compare October 28, 2025 14:09

Merge branch 'main' of ssh://github.com/hashicorp/terraform-provider-…

dfa88b1

…azurerm into shared_image_version_uefi_settings

wuxu92 reviewed Apr 10, 2026

View reviewed changes

Comment thread internal/services/compute/shared_schema.go Outdated

Comment thread internal/services/compute/shared_image_version_resource.go

yeoldegrove added 2 commits April 10, 2026 10:23

shared_image_version_resource - validate base64 string correctly

c6f1351

shared_image_version_resource - use ForceNew throughout `uefi_setti…

c542784

…ngs`

wuxu92 reviewed Apr 13, 2026

View reviewed changes

shared_image_version_resource - update docs for ForceNew

b9e1c85

yeoldegrove requested a review from wuxu92 April 13, 2026 08:08

wuxu92 approved these changes Apr 13, 2026

View reviewed changes

Comment thread internal/services/compute/image_resource_test.go Outdated

shared_image_version_resource - removed unneeded comment in tests

bf5582d

yeoldegrove requested a review from wuxu92 April 13, 2026 10:59

wuxu92 approved these changes Apr 13, 2026

View reviewed changes


		The `uefi_settings` block supports the following:

		* `signature_template_names` - (Required) A list of UEFI signature template names to include in the UEFI settings. Possible values are `MicrosoftUefiCertificateAuthorityTemplate`, `MicrosoftWindowsTemplate` and `NoSignatureTemplate`

Conversation

yeoldegrove commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

Uh oh!

yeoldegrove commented Dec 4, 2024

Uh oh!

github-actions bot commented Jan 20, 2025

Uh oh!

yeoldegrove commented Feb 4, 2025

Uh oh!

codgician commented Feb 4, 2025

Uh oh!

yeoldegrove commented Feb 17, 2025

Uh oh!

ms-zhenhua left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yeoldegrove commented Feb 24, 2025

Uh oh!

ms-zhenhua left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yeoldegrove commented Feb 26, 2025

Uh oh!

ms-zhenhua left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

catriona-m left a comment

Choose a reason for hiding this comment

Uh oh!

yeoldegrove commented Oct 27, 2025

Uh oh!

yeoldegrove commented Nov 11, 2025

Uh oh!

yeoldegrove commented Dec 1, 2025

Uh oh!

yeoldegrove commented Jan 13, 2026

Uh oh!

yeoldegrove commented Feb 2, 2026

Uh oh!

yeoldegrove commented Nov 20, 2024 •

edited

Loading