Skip to content

resource - fix TestAccResourceProviderRegistration_feature/requiresImport #28172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
teowa wants to merge 2 commits into from
Closed

resource - fix TestAccResourceProviderRegistration_feature/requiresImport #28172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
116735c
fix rp registration resource test
teowa Dec 4, 2024
05aac9b
fix feature registration
teowa Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 13 additions & 25 deletions internal/services/resource/resource_provider_registration_resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ func TestAccResourceProviderRegistration_requiresImport(t *testing.T) {
r := ResourceProviderRegistrationResource{}
data.ResourceTest(t, r, []acceptance.TestStep{
{
PreConfig: func() {
// Last error may cause resource provider still in `Registered` status.Need to unregister it before a new test.
if err := r.unRegisterProviders("Microsoft.AgFoodPlatform"); err != nil {
t.Fatalf("Failed to reset resource provider registration with error: %+v", err)
}
},
Config: r.basic("Microsoft.AgFoodPlatform"),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
Expand All @@ -64,32 +70,18 @@ func TestAccResourceProviderRegistration_feature(t *testing.T) {
{
PreConfig: func() {
// Last error may cause resource provider still in `Registered` status.Need to unregister it before a new test.
if err := r.unRegisterProviders("Microsoft.ApiSecurity"); err != nil {
if err := r.unRegisterProviders("Microsoft.ManufacturingPlatform"); err != nil {
t.Fatalf("Failed to reset feature registration with error: %+v", err)
}
},
Config: r.multiFeature(true, true),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
),
},
data.ImportStep(),
{
Config: r.multiFeature(true, false),
Config: r.feature(true),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
),
},
data.ImportStep(),
{
Config: r.multiFeature(false, true),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
),
},
data.ImportStep(),
{
Config: r.multiFeature(false, false),
Config: r.feature(false),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
),
Expand Down Expand Up @@ -198,23 +190,19 @@ func (r ResourceProviderRegistrationResource) unRegisterProvider(client *clients
return nil
}

func (ResourceProviderRegistrationResource) multiFeature(registered1 bool, registered2 bool) string {
func (ResourceProviderRegistrationResource) feature(registered bool) string {
return fmt.Sprintf(`
provider "azurerm" {
features {}
skip_provider_registration = true
}

resource "azurerm_resource_provider_registration" "test" {
name = "Microsoft.ApiSecurity"
feature {
name = "PP2CanaryAccessDEV"
registered = %t
}
name = "Microsoft.ManufacturingPlatform"
feature {
name = "PP3CanaryAccessDEV"
name = "DefaultFeature"
registered = %t
}
}
`, registered1, registered2)
`, registered)
}