[New Resource] azurerm_resource_provider_feature_registration

[jkroepke]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR manage a single feature registration of a whole provider. See #17185 for context.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/resource -run=TestAccResourceFeatureRegistration_ -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccResourceFeatureRegistration_basic
=== PAUSE TestAccResourceFeatureRegistration_basic
=== RUN   TestAccResourceFeatureRegistration_requiresImport
=== PAUSE TestAccResourceFeatureRegistration_requiresImport
=== CONT  TestAccResourceFeatureRegistration_basic
=== CONT  TestAccResourceFeatureRegistration_requiresImport
--- PASS: TestAccResourceFeatureRegistration_basic (1550.99s)
--- PASS: TestAccResourceFeatureRegistration_requiresImport (1551.17s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/resource      1553.366s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource_feature_registration - [New Resource] azurerm_resource_feature_registration [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #17185

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[github-actions]

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

[jkroepke]

Tests locally executed

[neil-yechenwei]

@jkroepke , In what scenarios would it be necessary to automate feature registration? I feel like this is a one-time task.

[kwevers]

@jkroepke , In what scenarios would it be necessary to automate feature registration? I feel like this is a one-time task.

It's a one-time task for each subscription. We regularly onboard new subscriptions so in that case it's very useful to be able to automate this. Until now, we've used an azapi_resource_action to do this, but it would be great if there was support for this in the azurerm provider.

[lemeurherve]

Any update for this PR?

[katbyte]

@lemeurherve @jkroepke - CI is failing across the board and needs to be fixed.

[jkroepke]

I lost access to an Azure subscription. I cant test it anymore.

[sreallymatt]

Test results:

(TeamCity Build Log)

[katbyte]

LGTM 🕯️