storage_account_blob_container_sas_data_source - add support for more permissions

[Kiliandeca]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR add support for more permissions on the storage container sas token data source as they are defined in: https://learn.microsoft.com/en-us/rest/api/storageservices/create-service-sas#permissions-for-a-directory-container-or-blob

To avoid a breaking change I switched the permissions properties to optional, existing terraform code should not be affected by this change and won't have more permissions than before.

As the storage_account_blob_container_sas_data_source and azurerm_storage_account_sas are very similar I also switched the permissions properties to optional to keep the same behavior between the two.

Another point to discuss, tags and find already exist in azurerm_storage_account_sas but are named respectively tag and filter. The documentation for them don't translate the permission letter to the same word . I followed the names of the container sas token documentation but you might want to reuse the same name as the storage account sas token to keep consistency in the provider, let me know and I'll edit the PR accordingly.

Tags t Read or write the tags on a blob.
Find f Find blobs with index tags.
https://learn.microsoft.com/en-us/rest/api/storageservices/create-service-sas#permissions-for-a-directory-container-or-blob

vs

• Tag (t): Permits blob tag operations.
• Filter (f): Permits filtering by blob tag.
  https://learn.microsoft.com/en-us/rest/api/storageservices/create-account-sas#specify-the-account-sas-parameters

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

make acctests SERVICE=storage TESTARGS='-run="(TestAccDataSourceStorageAccountBlobContainerSas_*|TestAccDataSourceStorageAccountSas_*)"' TESTTIMEOUT='60m'

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• storage_account_blob_container_sas_data_source - support for more permissions and make them optional

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #28421

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[mbfrahry]

Hey @Kiliandeca. This PR looks good but there are some formatting issues to take care of if you don't mind

[Kiliandeca]

Thanks for the review and sorry for the delay, I couldn't work on it before. I made all the changes requested to harmonise the doc formatting and the weird tab in the test file. Let me know if you need anything else done.

[Kiliandeca]

Hello @mbfrahry, sorry for tagging you but there hasn't been any news on this PR for months, do you need anything more from me?

[mbfrahry]

Hey @Kiliandeca, apologies for the delay in getting this in. I had to update it and open a new PR here #32149 but those changes are now and should go out in the next release. Thanks!