Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault_secret - add value_wo and value_wo_version #28947

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andreaswwilson
Copy link

@andreaswwilson andreaswwilson commented Mar 4, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR adds write-only functionality to key vault secrets.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
make acctests SERVICE="keyvault" TESTARGS='-skip=disappearsWhenParentKeyVaultDeleted -run=TestAccKeyVaultSecret'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/keyvault -skip=disappearsWhenParentKeyVaultDeleted -run=TestAccKeyVaultSecret -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccKeyVaultSecret_basic
=== PAUSE TestAccKeyVaultSecret_basic
=== RUN   TestAccKeyVaultSecret_writeOnlyValue
=== PAUSE TestAccKeyVaultSecret_writeOnlyValue
=== RUN   TestAccKeyVaultSecret_updateToWriteOnlyValue
=== PAUSE TestAccKeyVaultSecret_updateToWriteOnlyValue
=== RUN   TestAccKeyVaultSecret_requiresImport
=== PAUSE TestAccKeyVaultSecret_requiresImport
=== RUN   TestAccKeyVaultSecret_disappears
=== PAUSE TestAccKeyVaultSecret_disappears
=== RUN   TestAccKeyVaultSecret_complete
=== PAUSE TestAccKeyVaultSecret_complete
=== RUN   TestAccKeyVaultSecret_update
=== PAUSE TestAccKeyVaultSecret_update
=== RUN   TestAccKeyVaultSecret_updatingValueChangedExternally
=== PAUSE TestAccKeyVaultSecret_updatingValueChangedExternally
=== RUN   TestAccKeyVaultSecret_recovery
=== PAUSE TestAccKeyVaultSecret_recovery
=== RUN   TestAccKeyVaultSecret_withExternalAccessPolicy
=== PAUSE TestAccKeyVaultSecret_withExternalAccessPolicy
=== RUN   TestAccKeyVaultSecret_purge
=== PAUSE TestAccKeyVaultSecret_purge
=== CONT  TestAccKeyVaultSecret_basic
=== CONT  TestAccKeyVaultSecret_update
=== CONT  TestAccKeyVaultSecret_withExternalAccessPolicy
=== CONT  TestAccKeyVaultSecret_requiresImport
=== CONT  TestAccKeyVaultSecret_recovery
=== CONT  TestAccKeyVaultSecret_updateToWriteOnlyValue
=== CONT  TestAccKeyVaultSecret_updatingValueChangedExternally
=== CONT  TestAccKeyVaultSecret_complete
=== CONT  TestAccKeyVaultSecret_disappears
=== CONT  TestAccKeyVaultSecret_writeOnlyValue
=== CONT  TestAccKeyVaultSecret_purge
--- PASS: TestAccKeyVaultSecret_disappears (818.77s)
--- PASS: TestAccKeyVaultSecret_writeOnlyValue (841.80s)
--- PASS: TestAccKeyVaultSecret_purge (843.25s)
--- PASS: TestAccKeyVaultSecret_requiresImport (843.62s)
--- PASS: TestAccKeyVaultSecret_updateToWriteOnlyValue (850.45s)
--- PASS: TestAccKeyVaultSecret_basic (851.84s)
--- PASS: TestAccKeyVaultSecret_update (855.21s)
--- PASS: TestAccKeyVaultSecret_complete (858.88s)
--- PASS: TestAccKeyVaultSecret_updatingValueChangedExternally (876.93s)
--- PASS: TestAccKeyVaultSecret_withExternalAccessPolicy (893.26s)
--- PASS: TestAccKeyVaultSecret_recovery (1046.54s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/keyvault      1048.269s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_key_vault_secret - support for the value_wo and value_wo_version property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant