azurerm_nginx_deployment: Deprecate diagnose_support_enabled in v5.0

[arpith-f5]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

NGINXaaS is deprecating the diagnose_support_enabled field. Metrics will be enabled by default on all deployments and doesn't need to be explicity enabled via this field.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[arpith-f5]

@sreallymatt or @WodansSon since you have helped with NGINXaaS changes in the past. Would one of you be able to take a look at this?

[wuxu92]

Thanks @arpith-f5 for the changes, could you please address the merge conflict and the left comments, then we can process it forward.

[arpith-f5]

@wuxu92 I have fixed the merge conflicts and made the changes you requested. Could you take a look again?

[wuxu92]

Thanks for the update, I left some comments to update the pointer.From and pointer.To functions to aligh with the contributor guidance. otherwise everything LGTM

[arpith-f5]

@wuxu92 I have addressed your feedback, could you take a look again and merge if things look good

[wuxu92]

Thanks for the updates @arpith-f5 , LGTM 🚢

[neil-yechenwei]

THanks. LGTM

[wuxu92]

please remove the unnecessary lines

[arpith-f5]

please remove the unnecessary lines

done. @wuxu92 This PR has been under review for some time now. If there are no outstanding issues or concerns with the code, could we move forward with merging it?

[arpith-f5]

@neil-yechenwei @wuxu92 can one of you help in merging this PR.

[wuxu92]

Thanks, LGTM!

[sreallymatt]

Thanks @arpith-f5 - LGTM ✅