New resource: `azurerm_managed_lustre_file_system_auto_export_job` by jiaweitao001 · Pull Request #29908 · hashicorp/terraform-provider-azurerm

jiaweitao001 · 2025-06-19T06:37:32Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

WodansSon

@jiaweitao001, this is looking good so far, just a few comments I have left which I think should be addressed. Outside of those this LGTM! 🚀

WodansSon · 2025-06-20T05:00:02Z

internal/services/storagecache/managed_lustre_file_system_auto_export_job_resource.go

+			Type:         pluginsdk.TypeString,
+			Required:     true,
+			ForceNew:     true,
+			ValidateFunc: validation.StringIsNotEmpty,


Could we have a more robust validation for the name here? The documentation mentions the following requierments for the name field:

minLength: 2

maxLength: 80

pattern: ^[0-9a-zA-Z][-0-9a-zA-Z_]{0,78}[0-9a-zA-Z]$

Sure, will fix.

WodansSon · 2025-06-20T05:17:13Z

internal/services/storagecache/managed_lustre_file_system_auto_export_job_resource.go

+		"auto_export_prefixes": {
+			Type:     pluginsdk.TypeList,
+			Required: true,
+			Elem: &pluginsdk.Schema{
+				Type:         pluginsdk.TypeString,
+				ValidateFunc: validation.StringIsNotEmpty,
+			},
+		},


Number of maximum allowed paths for now is 1, so we should enforce that in the schema. Since this is an array of blob paths/prefixes which defaults to / can we also add a better validation function here as well?

Suggested change

"auto_export_prefixes": {

Type: pluginsdk.TypeList,

Required: true,

Elem: &pluginsdk.Schema{

Type: pluginsdk.TypeString,

ValidateFunc: validation.StringIsNotEmpty,

},

},

"auto_export_prefixes": {

Type: pluginsdk.TypeList,

Required: true,

MaxItems: 1,

Elem: &pluginsdk.Schema{

Type: pluginsdk.TypeString,

ValidateFunc: validation.StringIsNotEmpty,

},

},

Will change.

WodansSon · 2025-06-20T05:36:10Z

internal/services/storagecache/managed_lustre_file_system_auto_export_job_resource_test.go

+type ManagedLustreFileSystemAutoExportJobResource struct{}
+
+func (r ManagedLustreFileSystemAutoExportJobResource) Exists(ctx context.Context, clients *clients.Client, state *pluginsdk.InstanceState) (*bool, error) {
+	id, err := autoexportjobs.ParseAutoExportJobID(state.ID)


Can we add some more tests here, at least a requiresImport and an update?

WodansSon · 2025-06-20T05:46:40Z

website/docs/r/managed_lustre_file_system_auto_export_job.html.markdown

+* `auto_export_prefixes` - (Required) A list of prefixes that get auto exported to the cluster namespace.
+
+* `admin_status` - (Optional) The administrative status of the Auto Export Job. Possible values are `Enable` and `Disable`. Defaults to `Enable`.
+


I think we need to also add the Attributes Reference here as well, WDYT?

Suggested change

## Attributes Reference

In addition to the arguments listed above - the following attributes are exported:

* `id` - The Azure Managed Lustre File System Auto Export Job ID.

Sure. Will add .

catriona-m

Thanks @jiaweitao001, it looks like there are test failures on this in tc, could you take a look please?

------- Stdout: -------
=== RUN   TestAccManagedLustreFileSystemExportJob_requiresImport
=== PAUSE TestAccManagedLustreFileSystemExportJob_requiresImport
=== CONT  TestAccManagedLustreFileSystemExportJob_requiresImport
    testcase.go:173: Step 1/2 error: Error running apply: exit status 1
        Error: creating Aml Filesystem (Subscription: "*******"
        Resource Group Name: "acctestRG-amlfs-250724040016680629"
        Aml Filesystem Name: "acctest-amlfs-250724040016680629"): performing CreateOrUpdate: unexpected status 400 (400 Bad Request) with error: BadRequest: Storage Account acctestsa0bdzx is not found or is inaccessible.
          with azurerm_managed_lustre_file_system.test,
          on terraform_plugin_test.tf line 147, in resource "azurerm_managed_lustre_file_system" "test":
         147: resource "azurerm_managed_lustre_file_system" "test" {
        creating Aml Filesystem (Subscription: "*******"
        Resource Group Name: "acctestRG-amlfs-250724040016680629"
        Aml Filesystem Name: "acctest-amlfs-250724040016680629"): performing
        CreateOrUpdate: unexpected status 400 (400 Bad Request) with error:
        BadRequest: Storage Account acctestsa0bdzx is not found or is inaccessible.
--- FAIL: TestAccManagedLustreFileSystemExportJob_requiresImport (264.50s)
FAIL

github-actions · 2025-11-10T06:04:57Z

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

sreallymatt

Thanks @jiaweitao001, I've left some comments inline

sreallymatt · 2025-11-25T21:09:56Z

internal/services/storagecache/managed_lustre_file_system_auto_export_job_resource.go

+		"resource_group_name": commonschema.ResourceGroupName(),
+
+		"aml_file_system_name": {
+			Type:         pluginsdk.TypeString,
+			Required:     true,
+			ForceNew:     true,
+			ValidateFunc: validate.ManagedLustreFileSystemName,
+		},


When there are multiple properties required to create the parent resource's ID, we generally expose it as a single resource ID property, e.g.

"managed_lustre_file_system_id": commonschema.ResourceIDReferenceRequiredForceNew(&amlfilesystems.AmlFilesystemId{}),

Sure. Will address this.

sreallymatt · 2025-11-25T21:10:06Z

internal/services/storagecache/managed_lustre_file_system_auto_export_job_resource.go

+		"auto_export_prefixes": {
+			Type:     pluginsdk.TypeList,
+			Required: true,
+			MaxItems: 1,


Is MaxItems: 1 correct here? If users can only specify one prefix this should probably be auto_export_prefix and TypeString.

Unless this is meant to be MinItems: 1?

Right, this should be MinItems. Will fix.

sreallymatt · 2025-11-25T21:10:21Z

internal/services/storagecache/managed_lustre_file_system_auto_export_job_resource.go

+
+			existing, err := autoExportJobsClient.Get(ctx, id)
+			if err != nil && !response.WasNotFound(existing.HttpResponse) {
+				return fmt.Errorf("checking for existing Auto Export Job %s: %+v", id, err)


Suggested change

return fmt.Errorf("checking for existing Auto Export Job %s: %+v", id, err)

return fmt.Errorf("checking for existing %s: %+v", id, err)

sreallymatt · 2025-11-25T21:10:32Z

internal/services/storagecache/managed_lustre_file_system_auto_export_job_resource.go

+					if props.AdminStatus != nil && string(pointer.From(props.AdminStatus)) == string(autoexportjob.AutoExportJobAdminStatusEnable) {
+						state.AdminStatusEnabled = true
+					} else {
+						state.AdminStatusEnabled = false
+					}


We could simplify this to:

Suggested change

if props.AdminStatus != nil && string(pointer.From(props.AdminStatus)) == string(autoexportjob.AutoExportJobAdminStatusEnable) {

state.AdminStatusEnabled = true

} else {

state.AdminStatusEnabled = false

}

state.AdminStatusEnabled = pointer.From(props.AdminStatus) == autoexportjobs.AutoExportJobAdminStatusEnable

sreallymatt · 2025-11-25T21:10:57Z

internal/services/storagecache/managed_lustre_file_system_auto_export_job_resource_test.go

+		if response.WasNotFound(resp.HttpResponse) {
+			return pointer.To(false), nil
+		}


we generally just return any error encounter in the Exists func

Suggested change

if response.WasNotFound(resp.HttpResponse) {

return pointer.To(false), nil

}

Will remove.

sreallymatt · 2025-11-25T21:11:30Z

internal/services/storagecache/managed_lustre_file_system_auto_export_job_resource_test.go

+  location             = azurerm_resource_group.test.location
+
+  auto_export_prefixes = ["/"]
+  admin_status_enabled = true


Since this defaults to true, could you change it to false for the complete test to ensure we can update this property?

sreallymatt · 2025-11-25T21:12:08Z

internal/services/storagecache/managed_lustre_file_system_auto_export_job_resource_test.go

+  aml_file_system_name = azurerm_managed_lustre_file_system.test.name
+  location             = azurerm_resource_group.test.location
+
+  auto_export_prefixes = ["/"]


Could you update this value so it's different from the value specified in the basic test?

sreallymatt · 2025-11-25T21:12:26Z

internal/services/storagecache/managed_lustre_file_system_auto_export_job_resource_test.go

+  location             = azurerm_managed_lustre_file_system_auto_export_job.test.location
+
+  auto_export_prefixes = azurerm_managed_lustre_file_system_auto_export_job.test.auto_export_prefixes
+  admin_status_enabled = azurerm_managed_lustre_file_system_auto_export_job.test.admin_status_enabled


import config should match referenced config (r.basic)

Suggested change

admin_status_enabled = azurerm_managed_lustre_file_system_auto_export_job.test.admin_status_enabled

sreallymatt · 2025-11-25T21:13:09Z

website/docs/r/managed_lustre_file_system_auto_export_job.html.markdown

+
+* `auto_export_prefixes` - (Required) A list of prefixes that get auto exported to the cluster namespace.
+
+* `admin_status_enabled` - (Optional) Whether the administrative status of the Auto Export Job is enabled. Possible values are `true` and `false`. Defaults to `true`.


For booleans we don't need to include the possible values

Suggested change

* `admin_status_enabled` - (Optional) Whether the administrative status of the Auto Export Job is enabled. Possible values are `true` and `false`. Defaults to `true`.

* `admin_status_enabled` - (Optional) Whether the administrative status of the Auto Export Job is enabled. Defaults to `true`.

sreallymatt · 2025-11-25T21:13:16Z

website/docs/r/managed_lustre_file_system_auto_export_job.html.markdown

+
+## Timeouts
+
+The `timeouts` block allows you to specify [timeouts](https://www.terraform.io/docs/configuration/resources.html#timeouts) for certain actions:


We've recently updated the timeout reference url, would you mind changing this to

Suggested change

The `timeouts` block allows you to specify [timeouts](https://www.terraform.io/docs/configuration/resources.html#timeouts) for certain actions:

The `timeouts` block allows you to specify [timeouts](https://developer.hashicorp.com/terraform/language/resources/configure#define-operation-timeouts) for certain actions:

Will change.

sreallymatt

Hi @jiaweitao001, it looks like there are some test failures. A couple are due to a separate issue relating to the resource group resource, however there is one that will need to be addressed. Based on the error, it seems auto_export_prefixes may need to be ForceNew:

Error: updating Auto Export Job (Subscription: "*******"
        Resource Group Name: "acctestRG-amlfs-251126213709780808"
        Aml Filesystem Name: "acctest-amlfs-251126213709780808"
        Auto Export Job Name: "acctest-amlfsaej-251126213709780808"): performing CreateOrUpdate: unexpected status 409 (409 Conflict) with error: PropertyChangeNotAllowed: Changing property 'autoExportJob.properties.autoExportPrefixes' is not allowed.
          with azurerm_managed_lustre_file_system_auto_export_job.test,
          on terraform_plugin_test.tf line 195, in resource "azurerm_managed_lustre_file_system_auto_export_job" "test":
         195: resource "azurerm_managed_lustre_file_system_auto_export_job" "test" {

jiaweitao001 · 2025-12-01T02:46:54Z

Hi @jiaweitao001, it looks like there are some test failures. A couple are due to a separate issue relating to the resource group resource, however there is one that will need to be addressed. Based on the error, it seems auto_export_prefixes may need to be ForceNew:

Error: updating Auto Export Job (Subscription: "*******"
        Resource Group Name: "acctestRG-amlfs-251126213709780808"
        Aml Filesystem Name: "acctest-amlfs-251126213709780808"
        Auto Export Job Name: "acctest-amlfsaej-251126213709780808"): performing CreateOrUpdate: unexpected status 409 (409 Conflict) with error: PropertyChangeNotAllowed: Changing property 'autoExportJob.properties.autoExportPrefixes' is not allowed.
          with azurerm_managed_lustre_file_system_auto_export_job.test,
          on terraform_plugin_test.tf line 195, in resource "azurerm_managed_lustre_file_system_auto_export_job" "test":
         195: resource "azurerm_managed_lustre_file_system_auto_export_job" "test" {

Right. The provided description neglected this. Will fix.

…ort job create

The Create function performs three sequential long-running operations (waitForImportJobs, CreateOrUpdateThenPoll, UpdateThenPoll) that can cumulatively exceed the previous 60-minute timeout, causing context deadline exceeded errors when disabling admin status. Increase both Create and Update timeouts from 60 to 120 minutes and update documentation accordingly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jiaweitao001 requested a review from a team as a code owner June 19, 2025 06:37

github-actions bot added documentation size/XL waiting-response and removed waiting-response labels Jun 19, 2025

jiaweitao001 force-pushed the storage_cache_autoexport branch from d1f4c26 to 5ce6138 Compare June 19, 2025 07:30

github-actions bot removed the waiting-response label Jun 19, 2025

WodansSon requested changes Jun 20, 2025

View reviewed changes

github-actions bot assigned WodansSon Jun 20, 2025

github-actions bot added the waiting-response label Jun 20, 2025

katbyte removed the waiting-response label Jun 30, 2025

github-actions bot added waiting-response and removed waiting-response labels Jul 14, 2025

rcskosir added the new-resource label Aug 6, 2025

WodansSon removed their assignment Sep 5, 2025

jiaweitao001 requested a review from magodo as a code owner September 22, 2025 07:43

github-actions bot added waiting-response and removed waiting-response labels Sep 22, 2025

jiaweitao001 force-pushed the storage_cache_autoexport branch from 0a40211 to c105ea4 Compare September 24, 2025 03:13

github-actions bot added waiting-response and removed waiting-response labels Sep 24, 2025

jiaweitao001 added 5 commits September 24, 2025 11:22

New resource: azurerm_managed_lustre_file_system_auto_export_job

b75bbeb

sort imports

c7425fa

add complete test

7b4e382

fix acc test

87af82d

Address comments

4e97673

github-actions bot removed the waiting-response label Oct 9, 2025

catriona-m requested changes Oct 10, 2025

View reviewed changes

github-actions bot added the waiting-response label Oct 10, 2025

github-actions bot added the stale label Nov 10, 2025

Add timeout time for deleting resource

fa3d5f6

github-actions bot removed the waiting-response label Nov 10, 2025

jiaweitao001 removed the stale label Nov 10, 2025

github-actions bot added the waiting-response label Nov 10, 2025

Fix docs

a7ec3ca

github-actions bot removed the waiting-response label Nov 10, 2025

sreallymatt requested changes Nov 25, 2025

View reviewed changes

github-actions bot assigned sreallymatt Nov 25, 2025

github-actions bot added the waiting-response label Nov 25, 2025

Addressing comments

05a6ded

github-actions bot removed the waiting-response label Nov 26, 2025

sreallymatt requested changes Nov 28, 2025

View reviewed changes

github-actions bot added the waiting-response label Nov 28, 2025

github-actions bot removed the waiting-response label Dec 1, 2025

jiaweitao001 added 5 commits December 1, 2025 15:08

Making auto_export_prefixes to force new

e9e0f83

Removing import prefix from AMLFS

57eadd4

Add waiting logic for import job

4303806

storagecache: wait for import jobs and handle adminStatus on auto exp…

32ea5c7

…ort job create

Changing update method to avoid unexpected status code issue from API

d705489

github-actions bot added the waiting-response label Mar 18, 2026

Fix docs and name validation

0fc76ed

jiaweitao001 force-pushed the storage_cache_autoexport branch from 6d8c40f to 0fc76ed Compare March 18, 2026 07:32

jiaweitao001 and others added 2 commits March 25, 2026 16:03

Fix acc tests

bd306e8

		* `auto_export_prefixes` - (Required) A list of prefixes that get auto exported to the cluster namespace.

		* `admin_status` - (Optional) The administrative status of the Auto Export Job. Possible values are `Enable` and `Disable`. Defaults to `Enable`.

+## Attributes Reference
+In addition to the arguments listed above - the following attributes are exported:
+* `id` - The Azure Managed Lustre File System Auto Export Job ID.

	return fmt.Errorf("checking for existing Auto Export Job %s: %+v", id, err)
	return fmt.Errorf("checking for existing %s: %+v", id, err)

	if response.WasNotFound(resp.HttpResponse) {
	return pointer.To(false), nil
	}


		* `auto_export_prefixes` - (Required) A list of prefixes that get auto exported to the cluster namespace.

		* `admin_status_enabled` - (Optional) Whether the administrative status of the Auto Export Job is enabled. Possible values are `true` and `false`. Defaults to `true`.


		## Timeouts

		The `timeouts` block allows you to specify [timeouts](https://www.terraform.io/docs/configuration/resources.html#timeouts) for certain actions:

Conversation

jiaweitao001 commented Jun 19, 2025

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

Rollback Plan

Changes to Security Controls

Uh oh!

WodansSon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

catriona-m left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 10, 2025

Uh oh!

sreallymatt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sreallymatt left a comment