`azurerm_kubernetes_cluster_node_pool` - support for the `pod_ip_allocation_mode` property by hqhqhqhqhqhqhqhqhqhqhq · Pull Request #30827 · hashicorp/terraform-provider-azurerm

hqhqhqhqhqhqhqhqhqhqhq · 2025-10-10T18:33:45Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

azurerm_kubernetes_cluster_node_pool - support for the pod_ip_allocation_mode property

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_kubernetes_cluster_node_pool - support for the pod_ip_allocation_mode property

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

AI Assistance Disclosure

AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

ms-henglu · 2025-10-20T02:48:36Z

...r/github.com/hashicorp/go-azure-sdk/resource-manager/search/2025-05-01/services/constants.go

 	return &out, nil
 }

 type ComputeType string


Please rebase to main branch, this field is updated by other commits.

ms-henglu · 2025-10-20T02:49:20Z

internal/services/containers/kubernetes_cluster_node_pool_resource.go

+				string(agentpools.PodIPAllocationModeDynamicIndividual),
+				string(agentpools.PodIPAllocationModeStaticBlock),
+			}, false),
+			Description: "Pod IP Allocation Mode. The IP allocation mode for pods in the agent pool. Must be used with podSubnetId. The default is 'DynamicIndividual'.",


Please use terraform attribute pod_subnet_id instead of podSubnetId in the description.

ms-henglu · 2025-10-20T02:50:13Z

internal/services/containers/kubernetes_cluster_node_pool_resource.go

+			Type:     pluginsdk.TypeString,
+			Optional: true,
+			Default:  string(agentpools.PodIPAllocationModeDynamicIndividual),
+			ValidateFunc: validation.StringInSlice([]string{


Please change it to the helper function agentpools.PossibleValuesForPodIPAllocationMode()

ms-henglu · 2025-10-20T02:50:48Z

internal/services/containers/kubernetes_cluster_node_pool_resource_test.go

 	)
 }
+
+func (KubernetesClusterNodePoolResource) podIPAllocationModeConfig(data acceptance.TestData) string {


Please combine the two configuration function and pass the allocation mode as an argument.

ms-henglu · 2025-10-20T02:51:06Z

internal/services/containers/kubernetes_cluster_node_pool_resource_test.go

+}
+
+resource "azurerm_kubernetes_cluster" "test" {
+  name                = "acctestaks%d"


Please use %[1]d to format the string.

ms-henglu · 2025-10-20T02:51:24Z

internal/services/containers/kubernetes_cluster_node_pool_resource_test.go

+			Config: r.podIPAllocationModeConfigUpdated(data),
+			Check: acceptance.ComposeTestCheckFunc(
+				check.That(data.ResourceName).ExistsInAzure(r),
+				check.That(data.ResourceName).Key("pod_ip_allocation_mode").HasValue("DynamicIndividual"),


Please remove the checks on the properties.

ms-henglu · 2025-10-20T02:52:03Z

Please also check if this property could be set in the kubernete cluster's default node pool.

ms-henglu · 2025-11-12T06:07:49Z

internal/services/containers/kubernetes_nodepool.go

 		"vm_size":                       vmSize,
 		"workload_runtime":              workloadRunTime,
 		"pod_subnet_id":                 podSubnetId,
+		"pod_ip_allocation_mode":        podIPAllocationMode,


Please use "pointer.From(agentPool.PodIPAllocationMode)" to simplify it.

ms-henglu · 2025-11-12T06:08:20Z

internal/services/containers/kubernetes_cluster_resource_test.go

+
+	data.ResourceTest(t, r, []acceptance.TestStep{
+		{
+			Config: r.defaultNodePoolPodIPAllocationMode(data, "StaticBlock"),


Please add steps to test it switch from one value to another.

ms-henglu · 2025-11-12T06:09:26Z

internal/services/containers/kubernetes_cluster_node_pool_resource.go

 		}
+
+		if props.PodIPAllocationMode != nil {
+			d.Set("pod_ip_allocation_mode", string(*props.PodIPAllocationMode))


Please use pointer.From to simplify it.

ms-henglu

LGTM!

internal/services/containers/kubernetes_nodepool.go

teowa · 2025-12-01T00:20:37Z

Thanks @hqhqhqhqhqhqhqhqhqhqhq , LGTM!

…cation_mode` property

github-actions bot added documentation size/L waiting-response and removed waiting-response labels Oct 10, 2025

hqhqhqhqhqhqhqhqhqhqhq changed the title ~~Fix test configurations for Azure quota limitations~~ aks-node-pool-pod-ip-allocation-mode Oct 12, 2025

github-actions bot added dependencies and removed waiting-response labels Oct 18, 2025

hqhqhqhqhqhqhqhqhqhqhq changed the title ~~aks-node-pool-pod-ip-allocation-mode~~ azurerm_kubernetes_cluster_node_pool - support for the pod_ip_allocation_mode property Oct 18, 2025

github-actions bot added the enhancement label Oct 18, 2025

ms-henglu suggested changes Oct 20, 2025

View reviewed changes

github-actions bot assigned ms-henglu Oct 20, 2025

github-actions bot added waiting-response size/M and removed waiting-response size/L labels Oct 20, 2025

github-actions bot added size/L waiting-response and removed size/M labels Nov 12, 2025

ms-henglu suggested changes Nov 12, 2025

View reviewed changes

github-actions bot added waiting-response and removed waiting-response labels Nov 16, 2025

ms-henglu approved these changes Nov 17, 2025

View reviewed changes

hqhqhqhqhqhqhqhqhqhqhq marked this pull request as ready for review November 17, 2025 02:14

hqhqhqhqhqhqhqhqhqhqhq requested a review from WodansSon as a code owner November 17, 2025 02:14

teowa reviewed Nov 26, 2025

View reviewed changes

internal/services/containers/kubernetes_nodepool.go Outdated Show resolved Hide resolved

hqhqhqhqhqhqhqhqhqhqhq added 2 commits February 13, 2026 18:12

azurerm_kubernetes_cluster_node_pool - support for the `pod_ip_allo…

e942383

…cation_mode` property

Merge branch 'main' into feature/aks-node-pool-pod-ip-allocation-mode

ac4668f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_kubernetes_cluster_node_pool` - support for the `pod_ip_allocation_mode` property#30827

`azurerm_kubernetes_cluster_node_pool` - support for the `pod_ip_allocation_mode` property#30827
hqhqhqhqhqhqhqhqhqhqhq wants to merge 2 commits intohashicorp:mainfrom
hqhqhqhqhqhqhqhqhqhqhq:feature/aks-node-pool-pod-ip-allocation-mode

hqhqhqhqhqhqhqhqhqhqhq commented Oct 10, 2025 •

edited

Loading

Uh oh!

ms-henglu Oct 20, 2025

Uh oh!

ms-henglu Oct 20, 2025

Uh oh!

ms-henglu Oct 20, 2025

Uh oh!

ms-henglu Oct 20, 2025

Uh oh!

ms-henglu Oct 20, 2025

Uh oh!

ms-henglu Oct 20, 2025

Uh oh!

ms-henglu commented Oct 20, 2025

Uh oh!

ms-henglu Nov 12, 2025

Uh oh!

ms-henglu Nov 12, 2025

Uh oh!

ms-henglu Nov 12, 2025

Uh oh!

ms-henglu left a comment

Uh oh!

Uh oh!

teowa commented Dec 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

hqhqhqhqhqhqhqhqhqhqhq commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

AI Assistance Disclosure

Rollback Plan

Changes to Security Controls

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ms-henglu commented Oct 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ms-henglu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

teowa commented Dec 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hqhqhqhqhqhqhqhqhqhqhq commented Oct 10, 2025 •

edited

Loading