Skip to content

azurerm_nat_gateway - Support standardV2 sku#30957

Closed
QixiaLu wants to merge 7 commits intohashicorp:mainfrom
QixiaLu:nat_gateway_sku_update
Closed

azurerm_nat_gateway - Support standardV2 sku#30957
QixiaLu wants to merge 7 commits intohashicorp:mainfrom
QixiaLu:nat_gateway_sku_update

Conversation

@QixiaLu
Copy link
Copy Markdown
Collaborator

@QixiaLu QixiaLu commented Oct 27, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Support StandardV2 sku for azurerm_nat_gateway

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

acc tests against azurerm_nat_gateway, azurerm_public_ip and azurerm_public_ip_prefix. Failing tests also failed in the main
image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_nat_gateway - support for the StandardV2 sku
  • azurerm_public_ip - support for the StandardV2 sku
  • azurerm_public_ip_prefix - support for the StandardV2 sku

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #30752

AI Assistance Disclosure

  • AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@QixiaLu QixiaLu force-pushed the nat_gateway_sku_update branch from f84be3c to c91dd2f Compare November 30, 2025 22:41
Comment thread internal/services/network/public_ip_prefix_resource.go
Copy link
Copy Markdown
Collaborator

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@wuxu92 wuxu92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @QixiaLu LGTM 🚢

@fabiendelpierre
Copy link
Copy Markdown

fabiendelpierre commented Dec 2, 2025

FYI it looks like #31197 is working on the same thing.

@QixiaLu
Copy link
Copy Markdown
Collaborator Author

QixiaLu commented Dec 3, 2025

After discussing with Neil, we'll proceed with this PR (#31197) and close this one.

@QixiaLu QixiaLu closed this Dec 3, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 2, 2026

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for azurerm_nat_gateway StandardV2 sku

5 participants