azurerm_kubernetes_cluster data source - support for the outbound_type and bootstrap_profile#30983
Merged
sreallymatt merged 2 commits intohashicorp:mainfrom Mar 12, 2026
Conversation
…type` and `bootstrap_profile`
ziyeqf
reviewed
Nov 3, 2025
| } | ||
|
|
||
| if profile.OutboundType != nil { | ||
| values["outbound_type"] = string(*profile.OutboundType) |
Collaborator
There was a problem hiding this comment.
can we use pointer.From() for it?
ziyeqf
reviewed
Nov 3, 2025
|
|
||
| A `bootstrap_profile` block exports the following: | ||
|
|
||
| * `artifact_source` - The source from which artifacts are pulled during bootstrap. Possible values include `Direct` and `Cache`. |
Collaborator
There was a problem hiding this comment.
do we need possible values for a data source?
ziyeqf
reviewed
Nov 3, 2025
|
|
||
| * `network_mode` - Network mode to be used with Azure CNI. e.g. `bridge` or `transparent` | ||
|
|
||
| * `outbound_type` - The outbound (egress) routing method which is used for cluster egress traffic. Possible values include: `loadBalancer`, `userDefinedRouting`, `managedNATGateway`, `userAssignedNATGateway` and `none`. |
- Use pointer.From() for outbound_type field for safer nil handling - Remove 'Possible values' from data source documentation as these are computed fields
Collaborator
Author
|
Thanks @ziyeqf for the code review , I updated this PR as suggested. |
Collaborator
|
LGTM now, thanks @ms-henglu |
sreallymatt
approved these changes
Mar 12, 2026
Collaborator
sreallymatt
left a comment
sreallymatt
left a comment
There was a problem hiding this comment.
Thanks @ms-henglu - LGTM ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
Community Note
Description
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource- support for thething1property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #0000
AI Assistance Disclosure
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Note
If this PR changes meaningfully during the course of review please update the title and description as required.