New Resource: `azurerm_storage_mover_smb_mount_endpoint` by hqhqhqhqhqhqhqhqhqhqhq · Pull Request #31589 · hashicorp/terraform-provider-azurerm

hqhqhqhqhqhqhqhqhqhqhq · 2026-01-27T02:07:01Z

This PR adds a new resource azurerm_storage_mover_smb_mount_endpoint for managing Storage Mover SMB Mount Endpoints, enabling data migration from on-premises SMB file shares to Azure.

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR introduces the azurerm_storage_mover_smb_mount_endpoint resource, which allows users to create SMB Mount endpoints for migrating data from on-premises SMB file shares to Azure using Azure Storage Mover.

Properties:

name - (Required) The name of the endpoint
storage_mover_id - (Required) The ID of the Storage Mover
host - (Required) The hostname or IP address of the SMB server
share_name - (Required) The name of the SMB share
username_uri - (Optional) The Azure Key Vault secret URI for the username
password_uri - (Optional, Sensitive) The Azure Key Vault secret URI for the password
description - (Optional) A description for the endpoint

This resource uses API version 2025-07-01.

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.

New Resource

I have added an explanation of what my resource does and why it should be included in the provider.
I have written acceptance tests & documentation for my resource.
I have successfully run acceptance tests with my changes locally.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass.

Acceptance tests pass for the new resource.

Change Log

New Resource: azurerm_storage_mover_smb_mount_endpoint [New Resource: azurerm_storage_mover_smb_mount_endpoint #31589]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

N/A

AI Assistance Disclosure

AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

AI was used to assist with code generation, documentation, and test implementation.

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

No changes to security controls in this pull request.

Copilot

Pull request overview

Adds support for managing Azure Storage Mover SMB Mount Endpoints in the provider, including documentation and acceptance coverage.

Changes:

Introduces the azurerm_storage_mover_smb_mount_endpoint resource implementation (CRUD) wired to Microsoft.StorageMover/endpoints.
Adds acceptance tests for basic, complete (with Key Vault credentials), update, and import flows.
Publishes new resource documentation and registers the resource in the Storage Mover service.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
`website/docs/r/storage_mover_smb_mount_endpoint.html.markdown`	New docs page for the SMB mount endpoint resource, including examples and argument/timeout/import sections.
`internal/services/storagemover/storage_mover_smb_mount_endpoint_resource.go`	New resource implementation for SMB mount endpoints (create/read/update/delete) using the Storage Mover endpoints client.
`internal/services/storagemover/storage_mover_smb_mount_endpoint_resource_test.go`	New acceptance tests covering create/import/update flows, including Key Vault-backed credentials.
`internal/services/storagemover/registration.go`	Registers the new SMB mount endpoint resource with the Storage Mover service.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

internal/services/storagemover/storage_mover_smb_mount_endpoint_resource.go

website/docs/r/storage_mover_smb_mount_endpoint.html.markdown

gerrytan

Thx @hqhqhqhqhqhqhqhqhqhqhq , I left some comments regarding the schema design and validation.

Also can you please address the Copilot generated review comments.

gerrytan · 2026-03-16T02:56:43Z

internal/services/storagemover/storage_mover_smb_mount_endpoint_resource.go

+
+type StorageMoverSmbMountEndpointResource struct{}
+
+var _ sdk.ResourceWithUpdate = StorageMoverSmbMountEndpointResource{}


Need to also implement sdk.ResourceWithIdentity, please check guide-new-resource.md

gerrytan · 2026-03-16T02:57:37Z

internal/services/storagemover/storage_mover_smb_mount_endpoint_resource.go

+			Type:         pluginsdk.TypeString,
+			Required:     true,
+			ForceNew:     true,
+			ValidateFunc: validation.StringIsNotEmpty,


Can you please check if stronger validation than StringIsNotEmpty be used? Please check what kind of validation used in portal.

Same concern with other fields with "StringIsNotEmpty" validation.

host: Must be (1) IPv4 address or (2) hostname/FQDN → added validation for this

share_name: Portal: “Must be 1-80 characters and cannot contain: /[]:<> + = ;, *? or control characters” → Updated

description: Portal: “1024 characters max” → added validation for this

gerrytan · 2026-03-16T05:13:06Z

internal/services/storagemover/storage_mover_smb_mount_endpoint_resource.go

+			ValidateFunc: validation.StringIsNotEmpty,
+		},
+
+		"username_uri": {


This should be called username_key_vault_secret_id assuming it works if I supply a azurerm_key_vault_secret.mysecret.id here. Same apply to password_uri.

Both attributes are renamed to username_key_vault_secret_id and password_key_vault_secret_id

- examples/storage-mover: full example with SMB mount endpoint, validation-test-invalid.tf.example, README Made-with: Cursor

…oint)" This reverts commit 7a0f24b.

…d, rename credentials to key vault secret IDs - Implement ResourceWithIdentity: call SetResourceIdentityData after SetID in Create and in Read to fix 'Missing Resource Identity After Create' - Align Create with guide: return metadata.Encode after SetResourceIdentityData - Rename username_uri/password_uri to username_key_vault_secret_id/password_key_vault_secret_id in schema, docs and tests (PR feedback) Made-with: Cursor

…unt_endpoint)

Add stricter validation and credential handling for StorageMover SMB mount endpoints. Host now must be a valid IPv4 address or hostname/FQDN; share_name is limited to 1-80 characters and forbids control characters and a set of punctuation; description is limited to 1024 characters. Update Update() logic to require both username_key_vault_secret_id and password_key_vault_secret_id to be set together (or both empty) and to set/clear credentials accordingly. Adjust tests formatting and update R docs to describe the new validation rules.

… Read for description and credentials Made-with: Cursor

…fy target_endpoint docs Made-with: Cursor

Made-with: Cursor

github-actions bot added documentation dependencies service/storagemover size/XL labels Jan 27, 2026

hqhqhqhqhqhqhqhqhqhqhq changed the title ~~Feature/storage mover smb mount endpoint~~ New Resource: azurerm_storage_mover_smb_mount_endpoint Jan 28, 2026

github-actions bot added the ai-assisted label Jan 28, 2026

ms-henglu approved these changes Jan 30, 2026

View reviewed changes

hqhqhqhqhqhqhqhqhqhqhq force-pushed the feature/storage-mover-smb-mount-endpoint branch from b98ee4e to 2475163 Compare February 2, 2026 02:45

hqhqhqhqhqhqhqhqhqhqhq marked this pull request as ready for review February 3, 2026 02:31

hqhqhqhqhqhqhqhqhqhqhq requested review from a team, WodansSon and magodo as code owners February 3, 2026 02:31

rcskosir added the new-resource label Feb 9, 2026

hqhqhqhqhqhqhqhqhqhqhq force-pushed the feature/storage-mover-smb-mount-endpoint branch 2 times, most recently from 7504963 to b117070 Compare February 12, 2026 23:51

New Resource: azurerm_storage_mover_smb_mount_endpoint

b9219a7

hqhqhqhqhqhqhqhqhqhqhq force-pushed the feature/storage-mover-smb-mount-endpoint branch from b117070 to b9219a7 Compare February 12, 2026 23:58

hqhqhqhqhqhqhqhqhqhqhq requested a review from gerrytan February 13, 2026 02:15

gerrytan requested a review from Copilot March 16, 2026 02:55

Copilot started reviewing on behalf of gerrytan March 16, 2026 02:55 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

gerrytan suggested changes Mar 16, 2026

View reviewed changes

github-actions bot assigned gerrytan Mar 16, 2026

github-actions bot added the waiting-response label Mar 16, 2026

hqhqhqhqhqhqhqhqhqhqhq added 2 commits March 17, 2026 11:17

Add storage mover example and validation test (SMB mount endpoint)

7a0f24b

- examples/storage-mover: full example with SMB mount endpoint, validation-test-invalid.tf.example, README Made-with: Cursor

Revert "Add storage mover example and validation test (SMB mount endp…

284ac43

…oint)" This reverts commit 7a0f24b.

github-actions bot removed the waiting-response label Mar 17, 2026

github-actions bot added the waiting-response label Mar 17, 2026

Fix website-lint: terrafmt doc terraform blocks (storage_mover_smb_mo…

779123e

…unt_endpoint)

github-actions bot added waiting-response and removed waiting-response labels Mar 17, 2026

github-actions bot removed the waiting-response label Mar 17, 2026

hqhqhqhqhqhqhqhqhqhqhq requested a review from gerrytan March 17, 2026 06:11

hqhqhqhqhqhqhqhqhqhqhq added 3 commits March 17, 2026 18:03

storage_mover_smb_mount_endpoint: backticks in error, pointer.From in…

ea0a410

… Read for description and credentials Made-with: Cursor

storage_mover_smb_mount_endpoint: guide import-check error msg; clari…

65ba958

…fy target_endpoint docs Made-with: Cursor

docs: clarify SMB mount resource as Target Endpoint in portal

e84102d

Made-with: Cursor

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_storage_mover_smb_mount_endpoint`#31589

New Resource: `azurerm_storage_mover_smb_mount_endpoint`#31589
hqhqhqhqhqhqhqhqhqhqhq wants to merge 9 commits intohashicorp:mainfrom
hqhqhqhqhqhqhqhqhqhqhq:feature/storage-mover-smb-mount-endpoint

hqhqhqhqhqhqhqhqhqhqhq commented Jan 27, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gerrytan left a comment

Uh oh!

gerrytan Mar 16, 2026

Uh oh!

hqhqhqhqhqhqhqhqhqhqhq Mar 17, 2026

Uh oh!

gerrytan Mar 16, 2026

Uh oh!

hqhqhqhqhqhqhqhqhqhqhq Mar 17, 2026

Uh oh!

gerrytan Mar 16, 2026

Uh oh!

hqhqhqhqhqhqhqhqhqhqhq Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants


		type StorageMoverSmbMountEndpointResource struct{}

		var _ sdk.ResourceWithUpdate = StorageMoverSmbMountEndpointResource{}

Conversation

hqhqhqhqhqhqhqhqhqhqhq commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

New Resource

Testing

Change Log

Related Issue(s)

AI Assistance Disclosure

Rollback Plan

Changes to Security Controls

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gerrytan left a comment

Choose a reason for hiding this comment

Uh oh!

gerrytan Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

hqhqhqhqhqhqhqhqhqhqhq Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

gerrytan Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

hqhqhqhqhqhqhqhqhqhqhq Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

gerrytan Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

hqhqhqhqhqhqhqhqhqhqhq Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hqhqhqhqhqhqhqhqhqhqhq commented Jan 27, 2026 •

edited

Loading