`azurerm_mssql_elasticpool` - add support for the `high_availability_replica_count` property by catriona-m · Pull Request #31761 · hashicorp/terraform-provider-azurerm

catriona-m · 2026-02-17T15:50:07Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #28327

AI Assistance Disclosure

AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

sreallymatt

Thanks @catriona-m - left a couple comments inline

internal/services/mssql/mssql_elasticpool_resource.go

sreallymatt · 2026-02-17T17:02:09Z

internal/services/mssql/mssql_elasticpool_resource.go

The docs indicate you can have a maximum of 4 additional HA pools, we should validate for that (assuming it's accurate, I did not test provisioning with > 4)

sreallymatt · 2026-02-17T17:23:41Z

internal/services/mssql/mssql_elasticpool_resource.go

This default is problematic for users with existing elastic pools on a Hyperscale sku given Azure seems to default this to 1. We may have to set this to O+C until 5.0, or find another workaround, given we can't default this to 1 either.

thanks @sreallymatt I hadn't realised that. I can't think of another workaround that would allow us to avoid o+c so I've just added that for now. WDYT?

Copilot

Pull request overview

Adds support for configuring and reading high_availability_replica_count on the azurerm_mssql_elasticpool resource (and exposing it via the data source), aligning the provider with Azure’s Hyperscale elastic pool HA replica capability requested in #28327.

Changes:

Adds high_availability_replica_count to the azurerm_mssql_elasticpool resource schema, read/write logic, and diff-time validation.
Exposes high_availability_replica_count on the azurerm_mssql_elasticpool data source.
Updates docs and adds acceptance tests for the new attribute and SKU-tier restriction.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`internal/services/mssql/mssql_elasticpool_resource.go`	Adds the new schema field, wires it into create/update payloads, reads it back into state, and introduces a SKU-tier constraint in `CustomizeDiff`.
`internal/services/mssql/mssql_elasticpool_data_source.go`	Adds computed attribute to the data source and populates it from the API model.
`internal/services/mssql/mssql_elasticpool_resource_test.go`	Adds acceptance coverage for setting/updating replica count and for the non-Hyperscale validation error; also switches boolean pointer helper usage.
`website/docs/r/mssql_elasticpool.html.markdown`	Documents the new resource argument and its Hyperscale-only limitation.
`website/docs/d/mssql_elasticpool.html.markdown`	Documents the new data source attribute.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/services/mssql/mssql_elasticpool_resource.go

internal/services/mssql/mssql_elasticpool_resource_test.go

website/docs/r/mssql_elasticpool.html.markdown

github-actions · 2026-03-20T14:54:32Z

Build failure