`cognitive_account_rai_blocklist_resource` - support `tags` property and add validation for `name` property by ZiChuanBuXiu · Pull Request #31871 · hashicorp/terraform-provider-azurerm

ZiChuanBuXiu · 2026-03-03T02:50:24Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Support tags property
Add validation rule for name property
NOTE: created stand-along validation function RaiBlocklistName as this will be reused for RaiBlocklistItem resource in future
NOTE: the validation regex for RaiBlocklistName is aligned with the backend API enforced rule. The API spec and Azure Portal will be updated by the service team to align with the backend rule.
NOTE: the resource cognitive_account_rai_blocklist_item_resource implementation is in progress and will be in another PR
NOTE: the description change is due to Cognitive Account changed to AI Foundry in portal and this is for better user experience

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

cognitive_account_rai_blocklist_resource - support for the tags property [GH-00000]
cognitive_account_rai_blocklist_resource - add validation for the name property [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

AI Assistance Disclosure

AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…rule 1. Add `tags` field 2. Add validation rule for `name` for CognitiveRaiBlockLlist

website/docs/r/cognitive_account_rai_blocklist.html.markdown

promisinganuj

lgtm!

gerrytan

As discussed offline, the name validation is inconsistent between portal, spec and API. We need to confirm with service what is the intended validation, and get them to fix portal + spec too if needed.

gerrytan · 2026-03-09T02:48:09Z

website/docs/r/cognitive_account_rai_blocklist.html.markdown


 * `cognitive_account_id` - (Required) The ID of the Cognitive Services Account. Changing this forces a new Cognitive Account Rai Blocklist to be created.

+* `tags` - (Optional) A mapping of tags assigned to the resource.


A bit of scope creep, but I was struggling to correlate "Guardrail + Controls" -> blocklist in portal to this resource. Perhaps you can improve this docs a bit to help our customers.

this is fixed

…urce-update

gerrytan

Nice work @ZiChuanBuXiu , I left just 1 minor code style comment, otherwise this PR is good to go.

gerrytan · 2026-03-18T06:18:15Z

internal/services/cognitive/validate/rai_blocklist_name_test.go

+			}
+		})
+	}
+}


Nice 👍, thank you for adding unit tests

gerrytan · 2026-03-18T06:26:44Z

internal/services/cognitive/cognitive_account_rai_blocklist_resource.go


+			if model.Tags != nil {
+				payload.Tags = pointer.To(model.Tags)
+			}


Wrapping this in a != nil if block is not necessary. If model.Tags is nil (zero value for map), pointer.To will still return a pointer to this zero value and subsequent JSON serialisation logic will handle this just fine.

Do a codebase search for Tags.*pointer\.To and observe how we never wrap such code in this kind of if block.

gerrytan

Thanks @ZiChuanBuXiu this PR looks good to me.

Also thanks for running acctest against latest commit: https://hashicorp.teamcity.com/buildConfiguration/TF_AzureRM_AZURERM_SERVICE_PUBLIC_COGNITIVE/631922?buildTab=changes&expandRevisionsSection=true&showGraph=false

promisinganuj

lgtm!

sreallymatt

Thanks @ZiChuanBuXiu - LGTM ✅

cognitive_account_rai_blocklist_resoure - add field and validation …

4639bbb

…rule 1. Add `tags` field 2. Add validation rule for `name` for CognitiveRaiBlockLlist

github-actions bot added documentation service/cognitive-services size/L labels Mar 3, 2026

ZiChuanBuXiu changed the title ~~cognitive_account_rai_blocklist_resoure - add field and validation~~ cognitive_account_rai_blocklist_resource - add tags field and create validation for name field Mar 3, 2026

ZiChuanBuXiu changed the title ~~cognitive_account_rai_blocklist_resource - add tags field and create validation for name field~~ cognitive_account_rai_blocklist_resource - add property tags and validate name property Mar 3, 2026

ZiChuanBuXiu changed the title ~~cognitive_account_rai_blocklist_resource - add property tags and validate name property~~ cognitive_account_rai_blocklist_resource - add property tags and validate property name Mar 3, 2026

github-actions bot added ai-assisted enhancement labels Mar 3, 2026

ZiChuanBuXiu changed the title ~~cognitive_account_rai_blocklist_resource - add property tags and validate property name~~ cognitive_account_rai_blocklist_resource - support tags property and add validation for name property Mar 3, 2026

promisinganuj reviewed Mar 3, 2026

View reviewed changes

website/docs/r/cognitive_account_rai_blocklist.html.markdown Outdated Show resolved Hide resolved

Fix document

f68138f

ZiChuanBuXiu marked this pull request as ready for review March 4, 2026 00:04

ZiChuanBuXiu requested review from a team, WodansSon and magodo as code owners March 4, 2026 00:04

ZiChuanBuXiu requested a review from promisinganuj March 4, 2026 00:44

promisinganuj previously approved these changes Mar 4, 2026

View reviewed changes

gerrytan suggested changes Mar 9, 2026

View reviewed changes

ZiChuanBuXiu added 2 commits March 12, 2026 09:43

Merge branch 'main' into feature/cognitive_account_rai_blocklist_reso…

5d7044f

…urce-update

Update validation for

26bf37a

ZiChuanBuXiu dismissed promisinganuj’s stale review via 26bf37a March 11, 2026 22:59

ZiChuanBuXiu requested review from gerrytan and promisinganuj March 18, 2026 04:58

Improve description

207637f

gerrytan suggested changes Mar 18, 2026

View reviewed changes

Fix code style

3b64e83

ZiChuanBuXiu requested a review from gerrytan March 18, 2026 08:02

gerrytan approved these changes Mar 19, 2026

View reviewed changes

promisinganuj approved these changes Mar 19, 2026

View reviewed changes

sreallymatt approved these changes Mar 20, 2026

View reviewed changes

sreallymatt merged commit eded436 into hashicorp:main Mar 20, 2026
37 checks passed

github-actions bot added this to the v4.66.0 milestone Mar 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`cognitive_account_rai_blocklist_resource` - support `tags` property and add validation for `name` property#31871

`cognitive_account_rai_blocklist_resource` - support `tags` property and add validation for `name` property#31871
sreallymatt merged 6 commits intohashicorp:mainfrom
ZiChuanBuXiu:feature/cognitive_account_rai_blocklist_resource-update

ZiChuanBuXiu commented Mar 3, 2026 •

edited

Loading

Uh oh!

Uh oh!

promisinganuj left a comment

Uh oh!

gerrytan left a comment

Uh oh!

gerrytan Mar 9, 2026

Uh oh!

ZiChuanBuXiu Mar 18, 2026

Uh oh!

gerrytan left a comment

Uh oh!

gerrytan Mar 18, 2026

Uh oh!

gerrytan Mar 18, 2026

Uh oh!

ZiChuanBuXiu Mar 18, 2026

Uh oh!

gerrytan left a comment

Uh oh!

promisinganuj left a comment

Uh oh!

sreallymatt left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants


		* `cognitive_account_id` - (Required) The ID of the Cognitive Services Account. Changing this forces a new Cognitive Account Rai Blocklist to be created.

		* `tags` - (Optional) A mapping of tags assigned to the resource.

Conversation

ZiChuanBuXiu commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

AI Assistance Disclosure

Rollback Plan

Changes to Security Controls

Uh oh!

Uh oh!

promisinganuj left a comment

Choose a reason for hiding this comment

Uh oh!

gerrytan left a comment

Choose a reason for hiding this comment

Uh oh!

gerrytan Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

ZiChuanBuXiu Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

gerrytan left a comment

Choose a reason for hiding this comment

Uh oh!

gerrytan Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

gerrytan Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

ZiChuanBuXiu Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

gerrytan left a comment

Choose a reason for hiding this comment

Uh oh!

promisinganuj left a comment

Choose a reason for hiding this comment

Uh oh!

sreallymatt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ZiChuanBuXiu commented Mar 3, 2026 •

edited

Loading