list and identity implementation: azurerm_hpc_cache_nfs_target#31990
Closed
aayushsingh2502 wants to merge 3 commits intomainfrom
Closed
list and identity implementation: azurerm_hpc_cache_nfs_target#31990aayushsingh2502 wants to merge 3 commits intomainfrom
aayushsingh2502 wants to merge 3 commits intomainfrom
Conversation
aayushsingh2502
requested review from
a team,
WodansSon and
magodo
as code owners
Contributor
|
Build failure This pull request contains a build failure which needs addressed here . |
Contributor
|
Build failure This pull request contains a build failure which needs addressed here . |
mbfrahry
requested changes
Mar 18, 2026
Member
mbfrahry
left a comment
mbfrahry
left a comment
There was a problem hiding this comment.
Hey @aayushsingh2502, it looks like this service might be retired? Can you confirm?
| "github.com/hashicorp/terraform-provider-azurerm/internal/timeouts" | ||
| ) | ||
|
|
||
| //go:generate go run ../../tools/generator-tests resourceidentity -resource-name hpc_cache_nfs_target -service-package-name storagecache -properties "name,resource_group_name,cache_name" -known-values "subscription_id:data.Subscriptions.Primary" -test-sequential |
Member
There was a problem hiding this comment.
This can be removed
Suggested change
| //go:generate go run ../../tools/generator-tests resourceidentity -resource-name hpc_cache_nfs_target -service-package-name storagecache -properties "name,resource_group_name,cache_name" -known-values "subscription_id:data.Subscriptions.Primary" -test-sequential | |
| //go:generate go run ../../tools/generator-tests resourceidentity -resource-name hpc_cache_nfs_target -service-package-name storagecache -properties "name,resource_group_name,cache_name" -test-sequential |
Comment on lines
+25
to
+27
| HPCCacheNFSTargetListModel struct { | ||
| CacheId types.String `tfsdk:"cache_id"` | ||
| } |
Member
There was a problem hiding this comment.
For consistency, please pull this into it's own type struct
| } | ||
|
|
||
| func (r HPCCacheNFSTargetListResource) Metadata(_ context.Context, _ resource.MetadataRequest, response *resource.MetadataResponse) { | ||
| response.TypeName = "azurerm_hpc_cache_nfs_target" |
Member
There was a problem hiding this comment.
"azurerm_hpc_cache_nfs_target" should be a const variable since we use it in multiple places.
Suggested change
| response.TypeName = "azurerm_hpc_cache_nfs_target" | |
| response.TypeName = azureHPCCacheNFSTargetResourceName |
| } | ||
|
|
||
| func TestAccHPCCacheNFSTarget_usageModel(t *testing.T) { | ||
| t.Skip("The HPC Cache service is being retired, these test are no longer functional. Skipping...") |
Contributor
Author
|
closing the PR as the resource is retired |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
Implemented list and identity for azurerm_hpc_cache_nfs_target
teamcity Run link: https://hashicorp.teamcity.com/buildConfiguration/TF_AzureRM_AZURERM_SERVICE_PUBLIC_STORAGECACHE/631927?buildTab=overview
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource- support for thething1property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #0000
AI Assistance Disclosure
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Note
If this PR changes meaningfully during the course of review please update the title and description as required.