`web` - migrate from `azure-sdk-for-go` to `go-azure-sdk` by sreallymatt · Pull Request #31996 · hashicorp/terraform-provider-azurerm

sreallymatt · 2026-03-18T19:02:52Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Note: this PR is based off #31967, which should be merged first

This PR migrates all the non-deprecated web resources/datasources from azure-sdk-for-go to go-azure-sdk. Additionally I've cleaned up some old resource IDs and replaced them with resource IDs from go-azure-sdk or go-azure-helpers.

Most changes are split into separate commits per resource to help the reviewers. Not feasible to split into separate PRs due to most changes being intertwined

I did not replace the deprecated resources in the non-deprecated resources tests', I'll follow up with a separate PR to do so

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Tests running...

State Migration for `azurerm_app_service_custom_hostname_binding`:

manual tests for state migration

Terraform will perform the following actions:

# azurerm_app_service_custom_hostname_binding.test will be created

+ resource "azurerm_app_service_custom_hostname_binding" "test" {
+   app_service_name = "{name}"
+   hostname = "{name}"
+   id = (known after apply)
+   resource_group_name = "{name}"
+   ssl_state = (known after apply)
+   thumbprint = (known after apply)
+   virtual_ip = (known after apply) }

Plan: 1 to add, 0 to change, 0 to destroy.

╷ 
│ Warning: Deprecated Resource
│
│ with azurerm_app_service_plan.test,
│ on main.tf line 63, in resource "azurerm_app_service_plan" "test":
│ 63: resource "azurerm_app_service_plan" "test" {
│
│ The `azurerm_app_service_plan` resource has been superseded by the
│ `azurerm_service_plan` resource. Whilst this resource will continue to be
│ available in the 2.x and 3.x releases it is feature-frozen for compatibility
│ purposes, will no longer receive any updates and will be removed in a future
│ major release of the Azure Provider.
│
│ (and 5 more similar warnings elsewhere)
╵

Do you want to perform these actions?

Terraform will perform the actions described above. Only 'yes' will be accepted to approve.

Enter a value: yes

azurerm_app_service_custom_hostname_binding.test: Creating... 

azurerm_app_service_custom_hostname_binding.test: Creation complete after 5s [id=/subscriptions/{sub}/resourceGroups/{name}/providers/Microsoft.Web/sites/{name}/hostNameBindings/{name}]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

---
schema_version = 0:

~ cat terraform.tfstate | grep -C 5 "azurerm_app_service_custom_hostname_binding" }
] }, { "mode": "managed", "type": "

azurerm_app_service_custom_hostname_binding

", "name": "test", "provider": "provider[\"registry.terraform.io/hashicorp/azurerm\"]", "instances": [ { "schema_version": 0,

---

Local install:

~ tfa -refresh-only

╷
│ Warning: Provider development overrides are in effect
│
│ The following provider development overrides are set in the CLI
│ configuration:
│ - hashicorp/azurerm in ~/go/1.25.5/bin
│
│ The behavior may therefore not match any released version of the provider
│ and applying changes may cause the state to become incompatible with
│ published releases.
╵

data.azurerm_client_config.current: Reading...
data.azurerm_dns_zone.test: Reading...
...
azurerm_app_service_custom_hostname_binding.test: Refreshing state...[id=/subscriptions/{sub}/resourceGroups/{name}/providers/Microsoft.Web/sites/{name}/hostNameBindings/{name}]

No changes.

Your infrastructure still matches the configuration.

Terraform has checked that the real remote objects still match the result of your most recent changes, and found no differences.

╷
│ Warning: Deprecated Resource
│
│ with azurerm_app_service_plan.test,
│ on main.tf line 63, in resource "azurerm_app_service_plan" "test":
│ 63: resource "azurerm_app_service_plan" "test" {
│
│ The `azurerm_app_service_plan` resource has been superseded by the
│ `azurerm_service_plan` resource. This resource will be removed in v5.0 of
│ the AzureRM Provider.
│
│ (and 2 more similar warnings elsewhere)
╵

Would you like to update the Terraform state to reflect these detected changes?

Terraform will write these changes to the state without modifying any real infrastructure. There is no undo. Only 'yes' will be accepted to confirm.

Enter a value: yes

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

---

schema_version = 1:

~ cat terraform.tfstate | grep -C 5 "azurerm_app_service_custom_hostname_binding" } ] }, { "mode": "managed", "type": "

azurerm_app_service_custom_hostname_binding

", "name": "test", "provider": "provider[\"registry.terraform.io/hashicorp/azurerm\"]", "instances": [ { "schema_version": 1,

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #25942

AI Assistance Disclosure

AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

github-actions · 2026-03-18T19:08:48Z

Build failure

This pull request contains a build failure which needs addressed here .

github-actions · 2026-03-18T19:09:53Z

Build failure

This pull request contains a build failure which needs addressed here .

github-actions · 2026-03-20T16:53:17Z

Build failure

This pull request contains a build failure which needs addressed here .

…sdk`

…zure-sdk`

… to `go-azure-sdk`

…go-azure-sdk`

jackofallops

Thanks @sreallymatt - I know this is based on another open PR, so hopefully I've not repeated myself! Just a few comments to take a look at.

jackofallops · 2026-04-17T07:30:11Z

 		}

-		appSettingsResp, err := clients.Web.AppServicesClient.ListApplicationSettings(ctx, id.ResourceGroup, id.SiteName)
+		appSettingsResp, err := clients.Web.AppServicesClientV1.ListApplicationSettings(ctx, id.ResourceGroup, id.SiteName)


as mentioned in #31967 comments, this should be using the AppService client as per the resource.

jackofallops · 2026-04-17T07:52:47Z

+	existing, err := client.Get(ctx, id)
+	if !response.WasNotFound(existing.HttpResponse) {
 		if err != nil {


whilst this will work, idiom say check err first, which will keep this consistent with the rest of the provider.

jackofallops · 2026-04-17T07:57:30Z

+			ValidityInYears:   pointer.To(int64(d.Get("validity_in_years").(int))),
+		},
+		Location: location.Normalize(d.Get("location").(string)),
+		Tags:     utils.ExpandPtrMapStringString(d.Get("tags").(map[string]interface{})),


should probably switch this to tags? (needs import)

Suggested change

Tags: utils.ExpandPtrMapStringString(d.Get("tags").(map[string]interface{})),

Tags: tags.Expand(d.Get("tags").(map[string]interface{})),

jackofallops · 2026-04-17T08:07:38Z

+
+	if model := resp.Model; model != nil {
+		d.Set("location", location.Normalize(model.Location))
+		d.Set("tags", model.Tags)


Should probably flatten this for consistency?

Suggested change

d.Set("tags", model.Tags)

d.Set("tags", tags.Flatten(model.Tags))

jackofallops · 2026-04-17T08:08:25Z

+	}
+
+	if d.HasChange("tags") {
+		existing.Model.Tags = utils.ExpandPtrMapStringString(d.Get("tags").(map[string]interface{}))


Suggested change

existing.Model.Tags = utils.ExpandPtrMapStringString(d.Get("tags").(map[string]interface{}))

existing.Model.Tags = tags.Expand(d.Get("tags").(map[string]interface{}))

jackofallops · 2026-04-17T08:20:23Z

-		if props.IssueDate != nil {
-			issueDate = props.IssueDate.Format(time.RFC3339)
+	if model := resp.Model; model != nil {
+		d.Set("tags", model.Tags)


Suggested change

d.Set("tags", model.Tags)

d.Set("tags", tags.Flatten(model.Tags))

jackofallops · 2026-04-17T08:21:02Z

+	}
+
+	payload := certificates.CertificatePatchResource{
+		Tags: utils.ExpandPtrMapStringString(d.Get("tags").(map[string]interface{})),


Suggested change

Tags: utils.ExpandPtrMapStringString(d.Get("tags").(map[string]interface{})),

Tags: tags.Expand(d.Get("tags").(map[string]interface{})),

jackofallops · 2026-04-17T08:23:05Z

+	if !response.WasNotFound(existing.HttpResponse) {
+		if err != nil {


again, should check err first.

jackofallops · 2026-04-17T08:31:54Z

+		if response.WasNotFound(existing.HttpResponse) {
 			d.SetId("")


Looks like we're historically missing a log message here to inform the user why the resource is disappearing from state?

jackofallops · 2026-04-17T08:39:04Z


 	d.SetId(id.ID())

 	return pluginsdk.Retry(d.Timeout(pluginsdk.TimeoutCreate), func() *pluginsdk.RetryError {


Not one for now, but this needs reworking to remove the Retry()

github-actions Bot added bug enhancement documentation dependencies service/app-service service/logic service/network state-migration size/XL labels Mar 18, 2026

github-actions Bot added the waiting-response label Mar 18, 2026

github-actions Bot removed the waiting-response label Mar 18, 2026

sreallymatt force-pushed the mp/web-sdk-migration branch from 028dc00 to 4dda026 Compare March 19, 2026 19:23

github-actions Bot added waiting-response and removed waiting-response labels Mar 20, 2026

sreallymatt marked this pull request as ready for review March 23, 2026 22:44

sreallymatt requested review from a team, WodansSon and magodo as code owners March 23, 2026 22:44

sreallymatt added 9 commits March 26, 2026 15:15

deprecate web resources for 5.0, rename track 1 clients

cecd502

web - client updates

cd12b69

azurerm_app_service_certificate_binding - migrate to go-azure-sdk

6076c85

azurerm_app_service_certificate_order - migrate to go-azure-sdk

9209d54

azurerm_app_service_certificate - migrate to go-azure-sdk

2962e27

azurerm_app_service_custom_hostname_binding - migrate to `go-azure-…

da0d1f1

…sdk`

azurerm_app_service_managed_certificate - migrate to go-azure-sdk

e302572

azurerm_app_service_slot_custom_hostname_binding - migrate to `go-a…

98dc511

…zure-sdk`

azurerm_app_service_slot_virtual_network_swift_connection - migrate…

32a6197

… to `go-azure-sdk`

sreallymatt added 8 commits March 26, 2026 15:15

azurerm_app_service_virtual_network_swift_connection - migrate to `…

286b45f

…go-azure-sdk`

azurerm_function_app_host_keys - migrate to go-azure-sdk

acdd230

appservice/logic/web - old resource ID and client clean up

15a8b91

dependencies: go-azure-sdk - upgrade to v0.20260318.1180614

6c68aa9

minor improvement and removal of redundant SetId calls

a510e30

linting

24f54cd

tests: fix minor issues

9d73134

linting

1a20b07

sreallymatt force-pushed the mp/web-sdk-migration branch from 36ce222 to 1a20b07 Compare March 26, 2026 21:16

jackofallops requested changes Apr 17, 2026

View reviewed changes

github-actions Bot assigned jackofallops Apr 17, 2026

github-actions Bot added the waiting-response label Apr 17, 2026

	Tags: utils.ExpandPtrMapStringString(d.Get("tags").(map[string]interface{})),
	Tags: tags.Expand(d.Get("tags").(map[string]interface{})),

	d.Set("tags", model.Tags)
	d.Set("tags", tags.Flatten(model.Tags))

	existing.Model.Tags = utils.ExpandPtrMapStringString(d.Get("tags").(map[string]interface{}))
	existing.Model.Tags = tags.Expand(d.Get("tags").(map[string]interface{}))

		if !response.WasNotFound(existing.HttpResponse) {
		if err != nil {


		d.SetId(id.ID())

		return pluginsdk.Retry(d.Timeout(pluginsdk.TimeoutCreate), func() *pluginsdk.RetryError {

Conversation

sreallymatt commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

State Migration for azurerm_app_service_custom_hostname_binding:

Change Log

Related Issue(s)

AI Assistance Disclosure

Rollback Plan

Changes to Security Controls

Uh oh!

github-actions Bot commented Mar 18, 2026

Uh oh!

github-actions Bot commented Mar 18, 2026

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

jackofallops left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sreallymatt commented Mar 18, 2026 •

edited

Loading

State Migration for `azurerm_app_service_custom_hostname_binding`: