Skip to content

tooling - add VCR support to acceptance testing#32034

Merged
jackofallops merged 5 commits intomainfrom
f/go-vcr-enablement
Mar 27, 2026
Merged

tooling - add VCR support to acceptance testing#32034
jackofallops merged 5 commits intomainfrom
f/go-vcr-enablement

Conversation

@jackofallops
Copy link
Copy Markdown
Member

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR introduces VCR-based testing to the AzureRM provider. By recording and replaying the HTTP interactions between the Provider and the Azure API we can speed up our test suite, reduce costs, enable offline test execution, and ensure deterministic, reproducible test runs without needing live Azure resources every time.

WIP: Technical discussions are in progress that will decide some additional implementation details here.
NB: picked up some unrelated vendoring due to basing on later version of go-azure-sdk this will resolved when hashicorp/go-azure-sdk#1308 is merged and the provider bumped so this PR can be rebased.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • tooling - Add support for VCR based acceptance testing

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@github-actions
Copy link
Copy Markdown
Contributor

Build failure

This pull request contains a build failure which needs addressed here .

@github-actions
Copy link
Copy Markdown
Contributor

Build failure

This pull request contains a build failure which needs addressed here .

@github-actions
Copy link
Copy Markdown
Contributor

Build failure

This pull request contains a build failure which needs addressed here .

@github-actions
Copy link
Copy Markdown
Contributor

Build failure

This pull request contains a build failure which needs addressed here .

@github-actions
Copy link
Copy Markdown
Contributor

Build failure

This pull request contains a build failure which needs addressed here .

@github-actions
Copy link
Copy Markdown
Contributor

Build failure

This pull request contains a build failure which needs addressed here .

@jackofallops
Copy link
Copy Markdown
Member Author

Note to reviewer: Failure in deprecated functionality check is a false-positive, this line has not been touched.

@github-actions
Copy link
Copy Markdown
Contributor

Build failure

This pull request contains a build failure which needs addressed here .

@github-actions
Copy link
Copy Markdown
Contributor

Build failure

This pull request contains a build failure which needs addressed here .

@github-actions
Copy link
Copy Markdown
Contributor

Build failure

This pull request contains a build failure which needs addressed here .

partially working, found limitation in requests containing id derived IDs

reworked the recorder, folded in polling changes and completed data redactions for subscription IDs

patch up signalling for explicit record and replay modes

add vcr testing guide
sreallymatt
sreallymatt previously approved these changes Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Build failure

This pull request contains a build failure which needs addressed here .

Copy link
Copy Markdown
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚊

@jackofallops jackofallops marked this pull request as ready for review March 27, 2026 07:22
@jackofallops jackofallops requested review from a team, WodansSon and magodo as code owners March 27, 2026 07:22
@jackofallops jackofallops merged commit 22f7559 into main Mar 27, 2026
48 of 49 checks passed
@jackofallops jackofallops deleted the f/go-vcr-enablement branch March 27, 2026 07:23
@github-actions github-actions bot added this to the v4.67.0 milestone Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants