Storage: Upgrade API version from 2023-05-01 to 2025-06-01

[magodo]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR upgrades the Storage Mgmt Plane API version from 2023-05-01 to 2025-06-01. There are quite a few breaking changes due to the service team migrated the API spec via TypeSpec and changed the "Tags", which causes different package/type names for the go-azure-sdk.

The changes I've made include:

1. Update api version in the package paths:

   find . -name "*.go" | xargs sed -i 's;github.com/hashicorp/go-azure-sdk/resource-manager/storage/2023-05-01;github.com/hashicorp/go-azure-sdk/resource-manager/storage/2025-06-01;g'
   find . -name "*.go" | xargs sed -i 's;github.com/hashicorp/go-azure-sdk/resource-manager/storage/2025-06-01/blobservice;github.com/hashicorp/go-azure-sdk/resource-manager/storage/2025-06-01/blobservices;g'
   find . -name "*.go" | xargs sed -i 's;github.com/hashicorp/go-azure-sdk/resource-manager/storage/2025-06-01/fileservice;github.com/hashicorp/go-azure-sdk/resource-manager/storage/2025-06-01/fileservices;g'
   find . -name "*.go" | xargs sed -i 's;github.com/hashicorp/go-azure-sdk/resource-manager/storage/2025-06-01/localusers;github.com/hashicorp/go-azure-sdk/resource-manager/storage/2025-06-01/localuseroperationgroup;g'
   find . -name "*.go" | xargs sed -i 's;github.com/hashicorp/go-azure-sdk/resource-manager/storage/2025-06-01/objectreplicationpolicies;github.com/hashicorp/go-azure-sdk/resource-manager/storage/2025-06-01/objectreplicationpolicyoperationgroup;g'
   find . -name "*.go" | xargs sed -i 's;github.com/hashicorp/go-azure-sdk/resource-manager/storage/2025-06-01/queueservice;github.com/hashicorp/go-azure-sdk/resource-manager/storage/2025-06-01/queueservices;g'
   go mod tidy
   go mod vendor
   

2. Fix compiling errors (due to breaking changes) for code and test code.
3. Update the documents to reflect the new api versions (by running make document-fix).

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Among the 3 new test failures:

• TestAccLocalUser_passwordAndSSHKey: This seems to be a race condition when running together with other acctests. When I run it individually locally, it passes.

  terraform-provider-azurerm on  storage_api_20250601 via 🐹 v1.26.0-X:nodwarf5 took 4m14s
  💤 TF_ACC=1 go test -v -timeout 12h -run='TestAccLocalUser_passwordAndSSHKey' ./internal/services/storage
  === RUN   TestAccLocalUser_passwordAndSSHKey
  === PAUSE TestAccLocalUser_passwordAndSSHKey
  === CONT  TestAccLocalUser_passwordAndSSHKey
  --- PASS: TestAccLocalUser_passwordAndSSHKey (240.50s)
  PASS
  ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/storage	240.540s
  

• TestAccDataSourceStorageContainers_basic & TestAccDataSourceStorageContainers_prefix: These are caused by a bug I introduced during the SDK breaking change mitigation, which is then resolved in a follow up commit. The tests are passing now:

  💤 TF_ACC=1 go test -v -timeout 12h -run='TestAccDataSourceStorageContainers_basic|TestAccDataSourceStorageContainers_prefix' ./internal/services/storage
  === RUN   TestAccDataSourceStorageContainers_basic
  === PAUSE TestAccDataSourceStorageContainers_basic
  === RUN   TestAccDataSourceStorageContainers_prefix
  === PAUSE TestAccDataSourceStorageContainers_prefix
  === CONT  TestAccDataSourceStorageContainers_basic
  === CONT  TestAccDataSourceStorageContainers_prefix
  --- PASS: TestAccDataSourceStorageContainers_basic (132.28s)
  --- PASS: TestAccDataSourceStorageContainers_prefix (135.09s)
  PASS
  ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       135.117s
  

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

AI Assistance Disclosure

• AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[sreallymatt]

Thanks @magodo - LGTM ✅