azurerm_site_recovery_replicated_vm - remove ForceNew from managed_disk disk type fields

[ziyeqf]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The Azure REST API supports in-place updates to these fields via A2AVMManagedDiskUpdateDetails, and the provider's Update function already constructs the correct update payloads.
Thus we can remove the ForceNew from managed_disk and disk_type

Changing the managed_disk from TypeSet to TypeList, because previously, we only use disk_id to generate the hash of managed_disk, however, to allow in-place update for target_disk_type we have to include these in the hash function of this managed_disk block, otherwise changes on target_disk_type will be droped.
In that case, at creation, the disk_id is unknown, then the managed_disk will become computed, so d.Get() cannot read the value of it, which will cause the creaton fails.
So changing it to a ordered list (since the service does not gurantee the order) makes it clear.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_site_recovery_replicated_vm - remove ForceNew from managed_disk disk type fields [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

AI Assistance Disclosure

• AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[gerrytan]

Thank you @ziyeqf , I left 1 question and final acctest check. Other than these the PR looks good. Thanks for investigating / explaining the complexity of HashSet over DM.

I triggered another acctest run:

• 4.x: https://hashicorp.teamcity.com/viewQueued.html?itemId=692588
• 5.0: https://hashicorp.teamcity.com/viewQueued.html?itemId=692589

[gerrytan]

Should this comparison be case-insensitive too since you added DiffSuppressFunc: suppress.CaseDifference, to the schema above?

[gerrytan]

Thanks for addressing the feedbacks @ziyeqf . I've also checked the acctest results and the failures look unrelated to this change. This PR looks good to me.

[hc-github-team-tf-azure]

@ziyeqf - One or more tests failed in this PR. Please review the failures.

Build: 702295
PR: #32158

Total: 16
Passed: 13
Failed: 3
Test Duration: 3h 16m 6s

Test Details

Status	Test Name	Duration
❌ FAIL	TestAccSiteRecoveryReplicatedVm_withEdgeZones	799.004s
✅ PASS	TestAccSiteRecoveryReplicatedVm_zone2zone	2800.046s
✅ PASS	TestAccSiteRecoveryReplicatedVm_zone2zoneWithLoadBalancerBackendPool	2854.183s
✅ PASS	TestAccSiteRecoveryReplicatedVm_withTFOSettings	2896.048s
✅ PASS	TestAccSiteRecoveryReplicatedVm_withProximityPlacementGroup	2928.82s
✅ PASS	TestAccSiteRecoveryReplicatedVm_withAvailabilitySet	2976.958s
✅ PASS	TestAccSiteRecoveryReplicatedVm_updateDiskType	3376.572s
✅ PASS	TestAccSiteRecoveryReplicatedVm_targetDiskEncryption	3491.984s
✅ PASS	TestAccSiteRecoveryReplicatedVm_basic	3514.387s
✅ PASS	TestAccSiteRecoveryReplicatedVm_withVMSS	3613.682s
✅ PASS	TestAccSiteRecoveryReplicatedVm_targetVirtualMachineSize	3866.474s
✅ PASS	TestAccSiteRecoveryReplicatedVm_withCapacityReservationGroup	4064.165s
✅ PASS	TestAccSiteRecoveryReplicatedVm_withMultiVmGroup	4142.181s
✅ PASS	TestAccSiteRecoveryReplicatedVm_withBootDiagStorageAccount	4194.979s
❌ FAIL	TestAccSiteRecoveryReplicatedVm_des	11666.006s
❌ FAIL	TestAccSiteRecoveryReplicatedVm_withUnManagedDisks	11669.685s

[hc-github-team-tf-azure]

@ziyeqf - One or more tests failed in this PR. Please review the failures.

Testing in Beta version enabled

Build: 702296
PR: #32158

Total: 16
Passed: 13
Failed: 3
Test Duration: 3h 26m 19s

Test Details

Status	Test Name	Duration
❌ FAIL	TestAccSiteRecoveryReplicatedVm_withEdgeZones	709.484s
❌ FAIL	TestAccSiteRecoveryReplicatedVm_withUnManagedDisks	752.376s
✅ PASS	TestAccSiteRecoveryReplicatedVm_zone2zone	2762.787s
✅ PASS	TestAccSiteRecoveryReplicatedVm_zone2zoneWithLoadBalancerBackendPool	2825.873s
✅ PASS	TestAccSiteRecoveryReplicatedVm_withTFOSettings	2941.479s
✅ PASS	TestAccSiteRecoveryReplicatedVm_withCapacityReservationGroup	2982.036s
✅ PASS	TestAccSiteRecoveryReplicatedVm_withMultiVmGroup	3032.744s
✅ PASS	TestAccSiteRecoveryReplicatedVm_basic	3511.183s
✅ PASS	TestAccSiteRecoveryReplicatedVm_targetDiskEncryption	3515.085s
✅ PASS	TestAccSiteRecoveryReplicatedVm_withProximityPlacementGroup	3544.214s
✅ PASS	TestAccSiteRecoveryReplicatedVm_withVMSS	3570.492s
✅ PASS	TestAccSiteRecoveryReplicatedVm_withAvailabilitySet	3578.348s
✅ PASS	TestAccSiteRecoveryReplicatedVm_withBootDiagStorageAccount	3654.352s
✅ PASS	TestAccSiteRecoveryReplicatedVm_targetVirtualMachineSize	3841.752s
✅ PASS	TestAccSiteRecoveryReplicatedVm_updateDiskType	4461.425s
❌ FAIL	TestAccSiteRecoveryReplicatedVm_des	11698.33s