azurerm_orchestrated_virtual_machine_scale_set - support for tags within the network_interface block#32592
Open
aayushsingh2502 wants to merge 4 commits into
Open
azurerm_orchestrated_virtual_machine_scale_set - support for tags within the network_interface block#32592aayushsingh2502 wants to merge 4 commits into
aayushsingh2502 wants to merge 4 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Adds support for setting tags on the VMSS network interface configuration created by the network_interface block in azurerm_orchestrated_virtual_machine_scale_set, by upgrading the Compute VMSS SDK API version to one that exposes the tags field and wiring schema/expand/flatten + acceptance coverage.
Changes:
- Bumped the Compute
virtualmachinescalesetsSDK from2024-11-01to2025-04-01(vendored SDK update + internal import path updates). - Added
network_interface.tagsto the orchestrated VMSS schema and implemented expand (create/update) + flatten (read) support. - Added documentation and an acceptance test validating create/update/import behavior for
network_interface.tags.
Reviewed changes
Copilot reviewed 28 out of 187 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/r/orchestrated_virtual_machine_scale_set.html.markdown | Documents the new network_interface.tags argument. |
| vendor/modules.txt | Updates vendored module listing for the Compute VMSS SDK version bump. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/version.go | Updates default API version/user-agent for the VMSS SDK. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/README.md | Updates SDK docs for the new API version and adds examples. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/predicates.go | Adds predicate helpers for list/complete operations. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_zoneallocationpolicy.go | Adds new model type(s) introduced in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_winrmlistener.go | Adds new model type(s) introduced in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_winrmconfiguration.go | Adds new model type(s) introduced in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_windowsvmguestpatchautomaticbyplatformsettings.go | Adds new model type(s) introduced in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_windowsconfiguration.go | Adds new model type(s) introduced in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_vmsizeproperties.go | Adds new model type(s) introduced in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_vmscalesetscaleoutinputproperties.go | Updates model types to match 2025-04-01 schema. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_vmscalesetscaleoutinput.go | Adds new model type(s) introduced in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_vmscalesetconverttosingleplacementgroupinput.go | Adds new model type(s) introduced in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_vmgalleryapplication.go | Adds/updates models introduced in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_vmdisksecurityprofile.go | Adds new model type(s) introduced in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinestatuscodecount.go | Adds new model type(s) introduced in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetvmprofile.go | Adds/updates VM profile model for 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetvminstancerequiredids.go | Adds new model type(s) introduced in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetvminstanceids.go | Adds new model type(s) introduced in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetvmextensionssummary.go | Adds new model type(s) introduced in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetupdatevmprofile.go | Adds update models for PATCH support in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetupdatestorageprofile.go | Adds update models for PATCH support in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetupdatepublicipaddressconfigurationproperties.go | Adds update models for PATCH support in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetupdatepublicipaddressconfiguration.go | Adds Tags to update public IP config model. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetupdateproperties.go | Adds update models for PATCH support in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetupdateosprofile.go | Adds update models for PATCH support in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetupdateosdisk.go | Adds update models for PATCH support in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetupdatenetworkprofile.go | Adds update models for PATCH support in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetupdatenetworkconfigurationproperties.go | Adds update models for network config in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetupdatenetworkconfiguration.go | Adds Tags to update network configuration model. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetupdateipconfigurationproperties.go | Adds update models for IP config in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetupdateipconfiguration.go | Adds update models for IP config in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetupdate.go | Adds top-level update model used by PATCH operations. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetstorageprofile.go | Adds/updates storage profile models in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetskucapacity.go | Adds SKU capacity models in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetsku.go | Adds/updates SKU models in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetreimageparameters.go | Adds reimage parameter model(s) in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetpublicipaddressconfigurationproperties.go | Adds/updates public IP config models in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetpublicipaddressconfigurationdnssettings.go | Adds DNS settings model in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetpublicipaddressconfiguration.go | Adds Tags to public IP configuration model. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetproperties.go | Adds/updates VMSS properties models in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetosprofile.go | Adds/updates OS profile model in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetosdisk.go | Adds/updates OS disk model in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetnetworkprofile.go | Adds/updates network profile model in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetnetworkconfigurationproperties.go | Adds/updates network configuration properties in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetnetworkconfigurationdnssettings.go | Adds DNS settings model for network config in 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/model_virtualmachinescalesetnetworkconfiguration.go | Adds Tags to network configuration model (enables feature). |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/method_*.go | Adds/updates client methods for 2025-04-01 API surface. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/id_*.go | Adds/updates resource ID helpers for the SDK package. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/constants.go | Adds/updates constants/enums for 2025-04-01. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2025-04-01/virtualmachinescalesets/client.go | Adds the VMSS client constructor for the new API version. |
| vendor/github.com/hashicorp/go-azure-sdk/resource-manager/compute/2024-11-01/virtualmachinescalesets/model_proxyagentsettings.go | Removes an older model file as part of SDK regeneration. |
| internal/services/legacy/virtual_machine_scale_set_resource.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/legacy/virtual_machine_scale_set_resource_test.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/legacy/migration/legacy_vmss_v0_to_v1.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/windows_virtual_machine_scale_set_resource.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/windows_virtual_machine_scale_set_resource_test.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/windows_virtual_machine_scale_set_resource_other_test.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/virtual_machine_scale_set.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/virtual_machine_scale_set_update.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/virtual_machine_scale_set_standby_pool_resource.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/virtual_machine_scale_set_import.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/virtual_machine_scale_set_extension_resource.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/virtual_machine_scale_set_data_source.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/validate/orchestrated_vmss_public_ip_sku.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/ssh_keys.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/shared_schema.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/protected_settings_from_key_vault.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/orchestrated_virtual_machine_scale_set.go | Adds network_interface.tags schema + expand/flatten support; updates VMSS SDK import. |
| internal/services/compute/orchestrated_virtual_machine_scale_set_resource.go | Updates VMSS SDK import and ensures update path expands network interface tags. |
| internal/services/compute/orchestrated_virtual_machine_scale_set_resource_test.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/orchestrated_virtual_machine_scale_set_resource_network_test.go | Adds acceptance test for network_interface.tags; updates VMSS SDK import. |
| internal/services/compute/orchestrated_virtual_machine_scale_set_data_source.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/linux_virtual_machine_scale_set_resource.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/linux_virtual_machine_scale_set_resource_test.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/linux_virtual_machine_scale_set_resource_other_test.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/image_resource_test.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/helpers.go | Updates VMSS SDK import to 2025-04-01. |
| internal/services/compute/client/client.go | Updates VMSS SDK import to 2025-04-01. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
@aayushsingh2502 - One or more tests failed in this PR. Please review the failures. Total: 424 Test Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
This PR adds support for assigning
tagsto the network interface configuration created via thenetwork_interfaceblock of theazurerm_orchestrated_virtual_machine_scale_setresource.The Azure Compute
2025-04-01REST API exposes atagsfield on theVirtualMachineScaleSetNetworkConfiguration(and its update variant), allowing tags to be applied directly to the scale set's network interface configuration. This change surfaces that capability in Terraform.What changed
2024-11-01to2025-04-01/virtualmachinescalesets, which is where the newtagsfield is available.tagsattribute to thenetwork_interfaceblock schema (viacommonschema.Tags()).TestAccOrchestratedVirtualMachineScaleSet_networkInterfaceTags) covering create, update, and import of the tags.PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_orchestrated_virtual_machine_scale_set- support for thetagsproperty within thenetwork_interfaceblock [Support for tags for orchestrated_virtual_machine_scale_set/network_interface #32583]This is a (please select all that apply):
Related Issue(s)
Fixes #32583
AI Assistance Disclosure
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Note
If this PR changes meaningfully during the course of review please update the title and description as required.