azurerm_kubernetes_cluster, azurerm_kubernetes_cluster_node_pool - mark upgrade_settings as required in v5.0

[hqhqhqhqhqhqhqhqhqhqhq]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR marks upgrade_settings as required for azurerm_kubernetes_cluster default node pools and azurerm_kubernetes_cluster_node_pool resources under the v5 feature gate.

This replaces #31009.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

go test ./internal/services/containers -run 'TestAccKubernetesCluster(NodePool_upgradeSettingsMaxSurge|_upgradeSettings)' -count=1
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/containers

PATH="$(go env GOPATH)/bin:$PATH" make website-lint

Acceptance tests were not run locally in this pass. TeamCity prefix:

make acctests SERVICE='containers' TESTARGS='-run=TestAccKubernetesCluster(NodePool_upgradeSettingsMaxSurge|_upgradeSettings)' TESTTIMEOUT='60m'

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_kubernetes_cluster - mark upgrade_settings as required in v5.0 [azurerm_kubernetes_cluster, azurerm_kubernetes_cluster_node_pool - mark upgrade_settings as required in v5.0 #32608]
• azurerm_kubernetes_cluster_node_pool - mark upgrade_settings as required in v5.0 [azurerm_kubernetes_cluster, azurerm_kubernetes_cluster_node_pool - mark upgrade_settings as required in v5.0 #32608]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Replaces #31009

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

No.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[hc-github-team-tf-azure]

@hqhqhqhqhqhqhqhqhqhqhq - One or more tests failed in this PR. Please review the failures.

Testing in Beta version enabled

Build: 701462
PR: #32608

Total: 66
Passed: 62
Failed: 4
Test Duration: 3h 26m 35s

Test Details

Status	Test Name	Duration
✅ PASS	TestAccKubernetesClusterNodePool_availabilityZones	757.252s
✅ PASS	TestAccKubernetesClusterNodePoolDataSource_basic	808.071s
❌ FAIL	TestAccKubernetesClusterNodePool_kubeletAndLinuxOSConfigPartial	5.088s
✅ PASS	TestAccKubernetesClusterNodePool_autoScale	1137.846s
✅ PASS	TestAccKubernetesClusterNodePool_autoScaleUpdate	1150.059s
✅ PASS	TestAccKubernetesClusterNodePool_kubeletAndLinuxOSConfig	708.174s
✅ PASS	TestAccKubernetesClusterNodePool_other	853.253s
✅ PASS	TestAccKubernetesClusterNodePool_manualScale	822.358s
✅ PASS	TestAccKubernetesClusterNodePool_multiplePools	870.305s
✅ PASS	TestAccKubernetesClusterNodePool_capacityReservationGroup	2436.141s
✅ PASS	TestAccKubernetesClusterNodePool_manualScaleMultiplePools	996.802s
✅ PASS	TestAccKubernetesClusterNodePool_manualScaleMultiplePoolsUpdate	1301.701s
✅ PASS	TestAccKubernetesClusterNodePool_manualScaleUpdate	1004.402s
✅ PASS	TestAccKubernetesClusterNodePool_manualScaleIgnoreChanges	1059.865s
✅ PASS	TestAccKubernetesClusterNodePool_modeSystem	740.56s
✅ PASS	TestAccKubernetesClusterNodePool_manualScaleVMSku	1107.807s
✅ PASS	TestAccKubernetesClusterNodePool_nodeTaints	834.515s
✅ PASS	TestAccKubernetesClusterNodePool_nodeLabels	861.19s
✅ PASS	TestAccKubernetesClusterNodePool_modeUpdate	936.072s
✅ PASS	TestAccKubernetesClusterNodePool_nodePublicIP	883.236s
❌ FAIL	TestAccKubernetesClusterNodePool_requiresImport	385.948s
❌ FAIL	TestAccKubernetesClusterNodePool_spot	5.055s
✅ PASS	TestAccKubernetesClusterNodePool_spotWithMaxSurge	5.63s
✅ PASS	TestAccKubernetesClusterNodePool_spotWithMaxUnavailable	5.674s
✅ PASS	TestAccKubernetesClusterNodePool_upgradeSettingsWithoutMaxSurgeOrMaxUnavailable	5.643s
✅ PASS	TestAccKubernetesClusterNodePool_podSubnet	1040.177s
✅ PASS	TestAccKubernetesClusterNodePool_osDiskSizeGB	832.358s
✅ PASS	TestAccKubernetesClusterNodePool_osDiskType	815.965s
✅ PASS	TestAccKubernetesClusterNodePool_proximityPlacementGroupId	981.027s
✅ PASS	TestAccKubernetesClusterNodePool_spotWithOtherUpgradeSettings	808.409s
✅ PASS	TestAccKubernetesClusterNodePool_upgradeSettingsMaxSurge	1076.101s
✅ PASS	TestAccKubernetesClusterNodePool_virtualNetworkAutomatic	919.06s
✅ PASS	TestAccKubernetesClusterNodePool_upgradeSettingsMaxUnavailable	1128.61s
✅ PASS	TestAccKubernetesClusterNodePool_upgradeSettingsMaxSurgeToMaxUnavailable	1226.986s
✅ PASS	TestAccKubernetesClusterNodePool_virtualNetworkManual	818.199s
✅ PASS	TestAccKubernetesClusterNodePool_virtualNetworkMultipleSubnet	809.945s
✅ PASS	TestAccKubernetesClusterNodePool_windows	900.407s
✅ PASS	TestAccKubernetesClusterNodePool_windows2022	925.921s
✅ PASS	TestAccKubernetesClusterNodePool_windows2019	1113.068s
✅ PASS	TestAccKubernetesClusterNodePool_windowsAndLinux	987.599s
✅ PASS	TestAccKubernetesClusterNodePool_zeroSize	749.484s
✅ PASS	TestAccKubernetesClusterNodePool_hostEncryption	798.312s
✅ PASS	TestAccKubernetesClusterNodePool_maxSize	864.006s
✅ PASS	TestAccKubernetesClusterNodePool_sameSize	912.88s
✅ PASS	TestAccKubernetesClusterNodePool_ultraSSD	852.194s
✅ PASS	TestAccKubernetesClusterNodePool_osSkuUbuntu	976.389s
✅ PASS	TestAccKubernetesClusterNodePool_osSkuAzureLinux	796.829s
✅ PASS	TestAccKubernetesClusterNodePool_osSkuMigration	886.785s
✅ PASS	TestAccKubernetesClusterNodePool_dedicatedHost	847.475s
✅ PASS	TestAccKubernetesClusterNodePool_turnOnEnableAutoScalingWithDefaultMaxMinCountSettings	879.042s
✅ PASS	TestAccKubernetesClusterNodePool_workloadRuntime	762.065s
✅ PASS	TestAccKubernetesClusterNodePool_scaleDownMode	886.206s
✅ PASS	TestAccKubernetesClusterNodePool_windowsProfileOutboundNatEnabled	617.502s
✅ PASS	TestAccKubernetesClusterNodePool_workloadRuntimeKataVmIsolation	788.418s
✅ PASS	TestAccKubernetesClusterNodePool_nodeIPTags	748.771s
✅ PASS	TestAccKubernetesClusterNodePool_networkProfileComplete	735.283s
✅ PASS	TestAccKubernetesClusterNodePool_gpuInstance	750.813s
✅ PASS	TestAccKubernetesClusterNodePool_snapshotId	864.952s
✅ PASS	TestAccKubernetesClusterNodePool_networkProfileUpdate	1291.658s
✅ PASS	TestAccKubernetesClusterNodePool_gpuDriver	993.061s
❌ FAIL	TestAccKubernetesClusterNodePool_virtualNetworkOwnershipRaceCondition	1113.114s
✅ PASS	TestAccKubernetesClusterNodePool_VMSizeOmitted	722.464s
✅ PASS	TestAccKubernetesClusterNodePool_updateVmSizeAfterFailureWithTempWithoutOriginal	1029.961s
✅ PASS	TestAccKubernetesClusterNodePool_parallelPodSubnet	1293.514s
✅ PASS	TestAccKubernetesClusterNodePool_updateVmSizeAfterFailureWithTempAndOriginal	1301.661s
✅ PASS	TestAccKubernetesClusterNodePool_parallelCrossVNetSameSubnetName	817.508s

[hc-github-team-tf-azure]

@hqhqhqhqhqhqhqhqhqhqhq - One or more tests failed in this PR. Please review the failures.

Build: 701461
PR: #32608

Total: 67
Passed: 66
Failed: 1
Test Duration: 3h 36m 26s

Test Details

Status	Test Name	Duration
✅ PASS	TestAccKubernetesClusterNodePoolDataSource_basic	791.047s
✅ PASS	TestAccKubernetesClusterNodePool_availabilityZones	843.543s
✅ PASS	TestAccKubernetesClusterNodePool_autoScale	1139.255s
✅ PASS	TestAccKubernetesClusterNodePool_autoScaleUpdate	1213.734s
✅ PASS	TestAccKubernetesClusterNodePool_kubeletAndLinuxOSConfigPartial	824.641s
✅ PASS	TestAccKubernetesClusterNodePool_kubeletAndLinuxOSConfig	1100.789s
✅ PASS	TestAccKubernetesClusterNodePool_kubeletAndLinuxOSConfigDeprecated	897.772s
✅ PASS	TestAccKubernetesClusterNodePool_other	900.654s
✅ PASS	TestAccKubernetesClusterNodePool_capacityReservationGroup	2285.293s
✅ PASS	TestAccKubernetesClusterNodePool_multiplePools	1059.352s
✅ PASS	TestAccKubernetesClusterNodePool_manualScale	844.47s
✅ PASS	TestAccKubernetesClusterNodePool_manualScaleMultiplePools	983.447s
✅ PASS	TestAccKubernetesClusterNodePool_manualScaleIgnoreChanges	1030.396s
✅ PASS	TestAccKubernetesClusterNodePool_manualScaleMultiplePoolsUpdate	1480.828s
✅ PASS	TestAccKubernetesClusterNodePool_manualScaleUpdate	1061.678s
✅ PASS	TestAccKubernetesClusterNodePool_manualScaleVMSku	1074.563s
✅ PASS	TestAccKubernetesClusterNodePool_modeSystem	808.247s
✅ PASS	TestAccKubernetesClusterNodePool_modeUpdate	982.787s
✅ PASS	TestAccKubernetesClusterNodePool_nodeTaints	888.977s
✅ PASS	TestAccKubernetesClusterNodePool_nodePublicIP	766.115s
✅ PASS	TestAccKubernetesClusterNodePool_nodeLabels	831.85s
✅ PASS	TestAccKubernetesClusterNodePool_podSubnet	991.579s
✅ PASS	TestAccKubernetesClusterNodePool_osDiskSizeGB	848.084s
✅ PASS	TestAccKubernetesClusterNodePool_spotWithMaxSurge	17.95s
✅ PASS	TestAccKubernetesClusterNodePool_spotWithMaxUnavailable	16.668s
✅ PASS	TestAccKubernetesClusterNodePool_upgradeSettingsWithoutMaxSurgeOrMaxUnavailable	17.853s
✅ PASS	TestAccKubernetesClusterNodePool_osDiskType	816.605s
✅ PASS	TestAccKubernetesClusterNodePool_proximityPlacementGroupId	921.789s
✅ PASS	TestAccKubernetesClusterNodePool_requiresImport	827.355s
✅ PASS	TestAccKubernetesClusterNodePool_spot	812.775s
✅ PASS	TestAccKubernetesClusterNodePool_spotWithOtherUpgradeSettings	897.894s
✅ PASS	TestAccKubernetesClusterNodePool_upgradeSettingsMaxUnavailable	977.915s
✅ PASS	TestAccKubernetesClusterNodePool_upgradeSettingsMaxSurge	1072.718s
✅ PASS	TestAccKubernetesClusterNodePool_virtualNetworkAutomatic	912.709s
✅ PASS	TestAccKubernetesClusterNodePool_upgradeSettingsMaxSurgeToMaxUnavailable	1245.72s
✅ PASS	TestAccKubernetesClusterNodePool_virtualNetworkManual	838.995s
✅ PASS	TestAccKubernetesClusterNodePool_virtualNetworkMultipleSubnet	1074.465s
✅ PASS	TestAccKubernetesClusterNodePool_windows	1004.487s
✅ PASS	TestAccKubernetesClusterNodePool_windows2019	1004.269s
✅ PASS	TestAccKubernetesClusterNodePool_windows2022	965.27s
✅ PASS	TestAccKubernetesClusterNodePool_windowsAndLinux	982.863s
✅ PASS	TestAccKubernetesClusterNodePool_hostEncryption	790.388s
✅ PASS	TestAccKubernetesClusterNodePool_zeroSize	823.716s
✅ PASS	TestAccKubernetesClusterNodePool_maxSize	837.188s
✅ PASS	TestAccKubernetesClusterNodePool_sameSize	870.158s
✅ PASS	TestAccKubernetesClusterNodePool_ultraSSD	995.955s
✅ PASS	TestAccKubernetesClusterNodePool_osSkuUbuntu	806.903s
✅ PASS	TestAccKubernetesClusterNodePool_osSkuAzureLinux	932.65s
✅ PASS	TestAccKubernetesClusterNodePool_osSkuMigration	933.106s
✅ PASS	TestAccKubernetesClusterNodePool_dedicatedHost	888.979s
✅ PASS	TestAccKubernetesClusterNodePool_turnOnEnableAutoScalingWithDefaultMaxMinCountSettings	910.683s
✅ PASS	TestAccKubernetesClusterNodePool_scaleDownMode	841.611s
✅ PASS	TestAccKubernetesClusterNodePool_workloadRuntime	858.863s
✅ PASS	TestAccKubernetesClusterNodePool_windowsProfileOutboundNatEnabled	683.506s
✅ PASS	TestAccKubernetesClusterNodePool_workloadRuntimeKataVmIsolation	891.21s
✅ PASS	TestAccKubernetesClusterNodePool_nodeIPTags	751.158s
✅ PASS	TestAccKubernetesClusterNodePool_networkProfileComplete	801.986s
✅ PASS	TestAccKubernetesClusterNodePool_snapshotId	815.834s
✅ PASS	TestAccKubernetesClusterNodePool_gpuInstance	844.633s
✅ PASS	TestAccKubernetesClusterNodePool_networkProfileUpdate	1095.058s
✅ PASS	TestAccKubernetesClusterNodePool_gpuDriver	705.595s
❌ FAIL	TestAccKubernetesClusterNodePool_virtualNetworkOwnershipRaceCondition	1127.158s
✅ PASS	TestAccKubernetesClusterNodePool_VMSizeOmitted	716.388s
✅ PASS	TestAccKubernetesClusterNodePool_updateVmSizeAfterFailureWithTempWithoutOriginal	1024.319s
✅ PASS	TestAccKubernetesClusterNodePool_parallelPodSubnet	1354.069s
✅ PASS	TestAccKubernetesClusterNodePool_updateVmSizeAfterFailureWithTempAndOriginal	1250.08s
✅ PASS	TestAccKubernetesClusterNodePool_parallelCrossVNetSameSubnetName	1018.261s

[hqhqhqhqhqhqhqhqhqhqhq]

/test -b -q -s containers