azurerm_dedicated_host - remove None from the license_type property in 5.0

[sreallymatt]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Removes None from license_type in favour of omission indicating None

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

AI Assistance Disclosure

• AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[github-actions]

CI Build Failures for c45e5bc

2 jobs have failed and need to be addressed:

• ❌ Unit Tests — Run make test locally to reproduce and fix the failing unit tests. (logs)
• ❌ GoLang Linting — Run the Go linter locally with golangci-lint run -v ./internal/... and fix any reported issues. (logs)

For more information, please refer to our Contributing Guide.

[sreallymatt]

/test -b

[hc-github-team-tf-azure]

@sreallymatt - One or more tests failed in this PR. Please review the failures.

Build: 688084
PR: #32642

Total: 15
Passed: 14
Failed: 1
Test Duration: 0h 11m 19s

Test Details

Status	Test Name	Duration
❌ FAIL	TestAccDedicatedHost_requiresImport	116.243s
✅ PASS	TestAccDedicatedHostGroup_requiresImport	189.628s
✅ PASS	TestAccDedicatedHostGroup_basic	219.587s
✅ PASS	TestAccDedicatedHostGroup_resourceIdentity	231.304s
✅ PASS	TestAccDedicatedHostGroup_complete	236.493s
✅ PASS	TestAccDedicatedHostGroup_automaticPlacementEnabled	238.473s
✅ PASS	TestAccDataSourceAzureRMDedicatedHost_basic	337.831s
✅ PASS	TestAccDedicatedHost_licenseTypeNone	425.135s
✅ PASS	TestAccDedicatedHost_basic	444.12s
✅ PASS	TestAccDedicatedHost_resourceIdentity	445.164s
✅ PASS	TestAccDedicatedHost_complete	447.329s
✅ PASS	TestAccDedicatedHost_basicNewSku	451.894s
✅ PASS	TestAccDedicatedHost_update	504.014s
✅ PASS	TestAccDedicatedHost_autoReplaceOnFailure	536.343s
✅ PASS	TestAccDedicatedHost_licenseType	590.835s

[hc-github-team-tf-azure]

@sreallymatt - One or more tests failed in this PR. Please review the failures.

Testing in Beta version enabled

Build: 688085
PR: #32642

Total: 14
Passed: 13
Failed: 1
Test Duration: 0h 20m 7s

Test Details

Status	Test Name	Duration
❌ FAIL	TestAccDedicatedHost_basic	103.265s
✅ PASS	TestAccDedicatedHostGroup_requiresImport	162.371s
✅ PASS	TestAccDedicatedHostGroup_resourceIdentity	187.686s
✅ PASS	TestAccDedicatedHostGroup_complete	198.932s
✅ PASS	TestAccDedicatedHostGroup_basic	208.006s
✅ PASS	TestAccDedicatedHostGroup_automaticPlacementEnabled	265.624s
✅ PASS	TestAccDataSourceAzureRMDedicatedHost_basic	350.434s
✅ PASS	TestAccDedicatedHost_requiresImport	397.702s
✅ PASS	TestAccDedicatedHost_complete	419.749s
✅ PASS	TestAccDedicatedHost_basicNewSku	420.133s
✅ PASS	TestAccDedicatedHost_resourceIdentity	426.34s
✅ PASS	TestAccDedicatedHost_update	475.136s
✅ PASS	TestAccDedicatedHost_autoReplaceOnFailure	522.954s
✅ PASS	TestAccDedicatedHost_licenseType	562.873s

[sreallymatt]

Single failed test in both 4.x and 5.0 mode was due to a VM SKU quota issue, unrelated to these changes

[jackofallops]

Thanks @sreallymatt - LGTM 👍

[mstroob]

LGTM 🇧🇻