Skip to content

add logic to short circuit updates in deletion policy generation #11612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
modular-magician merged 1 commit into from
Feb 24, 2026
+4,165 −0
Merged

add logic to short circuit updates in deletion policy generation #11612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
13 changes: 13 additions & 0 deletions google-beta/services/accessapproval/resource_folder_access_approval_settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,19 @@ func resourceAccessApprovalFolderSettingsRead(d *schema.ResourceData, meta inter
}

func resourceAccessApprovalFolderSettingsUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceAccessApprovalFolderSettings().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceAccessApprovalFolderSettingsRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions google-beta/services/accessapproval/resource_organization_access_approval_settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,19 @@ func resourceAccessApprovalOrganizationSettingsRead(d *schema.ResourceData, meta
}

func resourceAccessApprovalOrganizationSettingsUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceAccessApprovalOrganizationSettings().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceAccessApprovalOrganizationSettingsRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions google-beta/services/accessapproval/resource_project_access_approval_settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,19 @@ func resourceAccessApprovalProjectSettingsRead(d *schema.ResourceData, meta inte
}

func resourceAccessApprovalProjectSettingsUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceAccessApprovalProjectSettings().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceAccessApprovalProjectSettingsRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions google-beta/services/accesscontextmanager/resource_access_context_manager_access_level.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,19 @@ func resourceAccessContextManagerAccessLevelRead(d *schema.ResourceData, meta in
}

func resourceAccessContextManagerAccessLevelUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceAccessContextManagerAccessLevel().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceAccessContextManagerAccessLevelRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions google-beta/services/accesscontextmanager/resource_access_context_manager_access_levels.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,19 @@ func resourceAccessContextManagerAccessLevelsRead(d *schema.ResourceData, meta i
}

func resourceAccessContextManagerAccessLevelsUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceAccessContextManagerAccessLevels().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceAccessContextManagerAccessLevelsRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions google-beta/services/accesscontextmanager/resource_access_context_manager_access_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,19 @@ func resourceAccessContextManagerAccessPolicyRead(d *schema.ResourceData, meta i
}

func resourceAccessContextManagerAccessPolicyUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceAccessContextManagerAccessPolicy().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceAccessContextManagerAccessPolicyRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions ...eta/services/accesscontextmanager/resource_access_context_manager_authorized_orgs_desc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,19 @@ func resourceAccessContextManagerAuthorizedOrgsDescRead(d *schema.ResourceData,
}

func resourceAccessContextManagerAuthorizedOrgsDescUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceAccessContextManagerAuthorizedOrgsDesc().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceAccessContextManagerAuthorizedOrgsDescRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions .../services/accesscontextmanager/resource_access_context_manager_gcp_user_access_binding.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,19 @@ func resourceAccessContextManagerGcpUserAccessBindingRead(d *schema.ResourceData
}

func resourceAccessContextManagerGcpUserAccessBindingUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceAccessContextManagerGcpUserAccessBinding().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceAccessContextManagerGcpUserAccessBindingRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions ...e-beta/services/accesscontextmanager/resource_access_context_manager_service_perimeter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,6 +1326,19 @@ func resourceAccessContextManagerServicePerimeterRead(d *schema.ResourceData, me
}

func resourceAccessContextManagerServicePerimeterUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceAccessContextManagerServicePerimeter().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceAccessContextManagerServicePerimeterRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions ...-beta/services/accesscontextmanager/resource_access_context_manager_service_perimeters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1152,6 +1152,19 @@ func resourceAccessContextManagerServicePerimetersRead(d *schema.ResourceData, m
}

func resourceAccessContextManagerServicePerimetersUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceAccessContextManagerServicePerimeters().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceAccessContextManagerServicePerimetersRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions google-beta/services/activedirectory/resource_active_directory_domain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,19 @@ func resourceActiveDirectoryDomainRead(d *schema.ResourceData, meta interface{})
}

func resourceActiveDirectoryDomainUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceActiveDirectoryDomain().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceActiveDirectoryDomainRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions google-beta/services/activedirectory/resource_active_directory_domain_trust.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,19 @@ func resourceActiveDirectoryDomainTrustRead(d *schema.ResourceData, meta interfa
}

func resourceActiveDirectoryDomainTrustUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceActiveDirectoryDomainTrust().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceActiveDirectoryDomainTrustRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions google-beta/services/activedirectory/resource_active_directory_peering.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,19 @@ func resourceActiveDirectoryPeeringRead(d *schema.ResourceData, meta interface{}
}

func resourceActiveDirectoryPeeringUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceActiveDirectoryPeering().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceActiveDirectoryPeeringRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions google-beta/services/alloydb/resource_alloydb_backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,19 @@ func resourceAlloydbBackupRead(d *schema.ResourceData, meta interface{}) error {
}

func resourceAlloydbBackupUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceAlloydbBackup().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceAlloydbBackupRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
1 change: 1 addition & 0 deletions google-beta/services/alloydb/resource_alloydb_cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1242,6 +1242,7 @@ func resourceAlloydbClusterRead(d *schema.ResourceData, meta interface{}) error
}

func resourceAlloydbClusterUpdate(d *schema.ResourceData, meta interface{}) error {

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
12 changes: 12 additions & 0 deletions google-beta/services/alloydb/resource_alloydb_instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,6 +925,18 @@ func resourceAlloydbInstanceRead(d *schema.ResourceData, meta interface{}) error
}

func resourceAlloydbInstanceUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceAlloydbInstance().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceAlloydbInstanceRead(d, meta)
}
var project string
config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
Expand Down
13 changes: 13 additions & 0 deletions google-beta/services/alloydb/resource_alloydb_user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,19 @@ func resourceAlloydbUserRead(d *schema.ResourceData, meta interface{}) error {
}

func resourceAlloydbUserUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceAlloydbUser().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceAlloydbUserRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions google-beta/services/apigateway/resource_api_gateway_api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,19 @@ func resourceApiGatewayApiRead(d *schema.ResourceData, meta interface{}) error {
}

func resourceApiGatewayApiUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceApiGatewayApi().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceApiGatewayApiRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions google-beta/services/apigateway/resource_api_gateway_api_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,19 @@ func resourceApiGatewayApiConfigRead(d *schema.ResourceData, meta interface{}) e
}

func resourceApiGatewayApiConfigUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceApiGatewayApiConfig().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceApiGatewayApiConfigRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions google-beta/services/apigateway/resource_api_gateway_gateway.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,19 @@ func resourceApiGatewayGatewayRead(d *schema.ResourceData, meta interface{}) err
}

func resourceApiGatewayGatewayUpdate(d *schema.ResourceData, meta interface{}) error {
clientSideFields := map[string]bool{"deletion_policy": true}
clientSideOnly := true
for field := range ResourceApiGatewayGateway().Schema {
if d.HasChange(field) && !clientSideFields[field] {
clientSideOnly = false
break
}
}
if clientSideOnly {
log.Print("[DEBUG] Only client-side changes detected. Cancelling update operation.")
return resourceApiGatewayGatewayRead(d, meta)
}

config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
Loading