Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an unsafe type assertion in google_artifact_registry_repository #22100

Conversation

modular-magician
Copy link
Collaborator

Fixes #21900 which is really a dupe of #21348. The latter also mentions a perma-lack-of-diff which this PR doesn't address (but the pending PR for the latter does). This PR only gets past the panic, but the lack of diff should be able to be worked around by changing the id of the policy a la:

   cleanup_policies {
     id     = "delete_older"
     action = "DELETE"
     condition {
       older_than = "62d"
     }
   }

to:

   cleanup_policies {
     id     = "delete_much_older"
     action = "DELETE"
     condition {
       older_than = "162d"
     }
   }
artifactregistry: fixed type assertion panic `google_artifact_registry_repository`

Derived from GoogleCloudPlatform/magic-modules#13445

…ashicorp#13445)

[upstream:dcc854f0bbe247a66a02a3b4a300b7a3473e1f3b]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner March 27, 2025 22:57
@modular-magician modular-magician merged commit 9551d61 into hashicorp:main Mar 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash of terraform provider during update of cleanup_policies
1 participant