Bug: fix waypoint_template.variable_options when no options is included #1242
Merged
drewmullen merged 11 commits intomainfrom Apr 3, 2025
Merged
Bug: fix waypoint_template.variable_options when no options is included #1242drewmullen merged 11 commits intomainfrom
waypoint_template.variable_options when no options is included #1242drewmullen merged 11 commits intomainfrom
Conversation
3 tasks
drewmullen
force-pushed
the
bug-waypointtemplate-options
branch
2 times, most recently
from
b68d2c4 to
b020f7b
Compare
drewmullen
force-pushed
the
bug-waypointtemplate-options
branch
from
b020f7b to
c14899a
Compare
HenryEstberg
approved these changes
Apr 2, 2025
Contributor
HenryEstberg
left a comment
HenryEstberg
left a comment
There was a problem hiding this comment.
Looks good! I did some manual testing by pulling your branch which all looked good. As long as the acceptance tests are passing, this is good to go. Thanks for chasing this down!
yuriikomarss
pushed a commit
to cargurus/terraform-provider-hcp
that referenced
this pull request
Apr 29, 2025
…cluded (hashicorp#1242) * Do not call ElementAs when parsing variable_options.options * modify existing test to validate no `options` works * changelog: waypoint_template bug fix * changelog: waypoint_template bug fix * update test to include new ncm variable * using fun variable names out of positive peer pressure * Add test changes to waypoint resources * options not required for variablesets * update docs to show options is optional * fix test input * include changelog entry for fix on addon_definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Closes: #1240, #1244
Instead of adding a new test I just modified the existing test to validate setting no
optionsworks. I'm not able to run acc tests without access to your env.🏗️ Acceptance tests
Output from acceptance testing: