Skip to content

Docs only: Add aws resources routing back to the HVN to AWS Transit Gateway Attachment example#1253

Merged
nphilbrook merged 8 commits intomainfrom
nphilbrook_aws_tgw_attachment_example_route
Apr 11, 2025
Merged

Docs only: Add aws resources routing back to the HVN to AWS Transit Gateway Attachment example#1253
nphilbrook merged 8 commits intomainfrom
nphilbrook_aws_tgw_attachment_example_route

Conversation

@nphilbrook
Copy link
Copy Markdown
Collaborator

@nphilbrook nphilbrook commented Apr 9, 2025

🛠️ Description

Docs only change - the example code for hcp_aws_transit_gateway_attachment was missing the required AWS resources to route return traffic to the HVN. I did test the full example code.

Additionally added to the contributing/README.md as it took me a few minutes to realize I needed to edit the source of the example code, not the generate documentation.

@nphilbrook nphilbrook requested review from a team as code owners April 9, 2025 19:28
@nphilbrook nphilbrook marked this pull request as ready for review April 10, 2025 16:36
@nphilbrook nphilbrook added the documentation Improvements or additions to documentation label Apr 10, 2025
Copy link
Copy Markdown
Contributor

@garvit-hashicorp garvit-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@nphilbrook nphilbrook changed the title Docs only: Add aws_route resource routing back to the HVN to AWS Transit Gateway Attachment example Docs only: Add aws resources routing back to the HVN to AWS Transit Gateway Attachment example (#1253) Apr 11, 2025
@nphilbrook nphilbrook changed the title Docs only: Add aws resources routing back to the HVN to AWS Transit Gateway Attachment example (#1253) Docs only: Add aws resources routing back to the HVN to AWS Transit Gateway Attachment example Apr 11, 2025
@nphilbrook nphilbrook merged commit 54414b5 into main Apr 11, 2025
8 checks passed
@nphilbrook nphilbrook deleted the nphilbrook_aws_tgw_attachment_example_route branch April 11, 2025 11:58
yuriikomarss pushed a commit to cargurus/terraform-provider-hcp that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants