Do client-side blocking for group operations with an operation id in response#1260
Merged
Do client-side blocking for group operations with an operation id in response#1260
Conversation
alexmunda
reviewed
Apr 23, 2025
Comment on lines
+32
to
+36
| if loc.ProjectID == "" { | ||
| waitParams.LocationProjectID = "-" | ||
| } else { | ||
| waitParams.LocationProjectID = loc.ProjectID | ||
| } |
Contributor
There was a problem hiding this comment.
nit: save an else by defaulting to "-" and setting when non ""
alexmunda
approved these changes
Apr 23, 2025
huikang
approved these changes
Apr 23, 2025
yuriikomarss
pushed a commit
to cargurus/terraform-provider-hcp
that referenced
this pull request
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
🏗️ Acceptance tests
I did not run the acceptance tests, but it seems that CI does now. Maybe this PR template is out of date?
I tested locally by first creating an hcp group, then changing its display_name so that an update was made, then defining group members, as in:
Finally I deleted the group. For each test I looked at DD to confirm that after the response from cloud-iam, Wait requests were issued to cloud-operation for the returned operationID.
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccXXX' ...