Added min_vault_version details to HVD TF provider#1448
Merged
sivajayaraman merged 3 commits intomainfrom Mar 3, 2026
Merged
Conversation
|
TestAcc Vault was failing. Re-ran it again just in case. |
Contributor
Author
@gautam-hashicorp . I checked this, We have issue with VPC limit for acceptance test. Have to clean up some HVNs to make this succeed. |
|
Got it. Let me know when that is done too. Thanks Siva! |
Contributor
Author
|
@gautam-hashicorp . Can you check now? Thank you! |
|
Thanks for the changes, SIva! |
jasonpilz
approved these changes
Mar 2, 2026
sivajayaraman
deleted the
sivajayaraman/min-version-details-in-hvd-provider
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Updates the
min_vault_versionattribute description for thehcp_vault_clusterresource and data source to include a sample version value and a link to the HCP changelog , making it easier for users to discover valid versions. Users previously had no guidance on valid values formin_vault_versionor where to find them. This change reduces friction by providing a concrete example and pointing to the changelog as the canonical source for available versions.🏗️ Acceptance tests
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccXXX' ...PCI review checklist
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've worked with GRC to document the impact of any changes to security controls.
Examples of changes to controls include access controls, encryption, logging, etc.
If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.