- 
                Notifications
    
You must be signed in to change notification settings  - Fork 125
 
Add resources for uuid v4 and v7 #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3839326    to
    8411ece      
    Compare
  
    | 
           Hi @masongup-mdsol, I can review this after signing the CLA. 👍🏽  | 
    
| 
           Ah okay, I thought I had signed it already, but I guess I didn't finish the workflow properly before. I think it should be good now.  | 
    
5eca8b5    to
    b388522      
    Compare
  
    | 
           Hi @masongup-mdsol thank you for your contribution! 😄 This looks pretty reasonable, I wanted to ask if you could create a changelog entry for this as an enhancement. And also if you can run  Thank you!  | 
    
| 
           Thanks @rainkwan, I have done both  | 
    
b8a9c92    to
    dfd7172      
    Compare
  
    | 
           any timeline regarding when this can be released?  | 
    
dfd7172    to
    4d6acc1      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems reasonable to me
Related Issue
Fixes #402
Fixes #511
Description
The UUIDs generated by the existing
random_uuidresource are not valid UUIDs per RFC 4122, so they cause problems when a user attempts to use them in a system which expects UUIDs to be a specific version. Per the discussion on #402, I have done this by cloning the existing uuid resource, renaming it as uuid4 and uuid7 respectively, and using the Google Go UUID library instead with the appropriate methods to generate valid UUIDs of the appropriate versions. This way, users of the existinguuidresource will continue to have the same behavior without making any changes. Users who need one of these UUID versions can use the specific resource for that so that it is clear to any readers of the code what version is being used and that that version is being used intentionally.Rollback Plan
Changes to Security Controls
Given that this is random data, there are no security controls involved.