-
Notifications
You must be signed in to change notification settings - Fork 164
[tfe_workspace_run] Allow configuration without apply
and destroy
blocks
#1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tmatilai
wants to merge
17
commits into
hashicorp:main
Choose a base branch
from
tmatilai:allow-empty-workspace-run
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… blocks Allow configuring the `tfe_workspace_run` resource without `apply` and `destroy` blocks. This makes it possible to remove the `destroy` block from a resource without an `apply` block, to avoid a destroy run to be scheduled like when removing the whole resource.
This would be especially useful when changing the execution mode of a workspace from remote/agent to local. For locally executed workspaces the API obviously fails if runs are tried to be created. So the only option now would be to remove the |
tmatilai
commented
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow configuring the
tfe_workspace_run
resource withoutapply
anddestroy
blocks. This makes it possible to remove thedestroy
block from a resource without anapply
block, to avoid a destroy run to be scheduled like when removing the whole resource.This would be especially useful when managing workspaces and workspace runs with automation, allowing to leave the empty resources in state without worrying about accidental destroy runs.
Remember to:
Testing plan
Example configuration, which errors out without this change.
Output from acceptance tests
[The test setup seems to have changed, disallowing running the test suite using own HCP Terraform organization]