[TF-27883] Add agent execution mode and pool to test config#1832
Merged
[TF-27883] Add agent execution mode and pool to test config#1832
Conversation
01cc650 to
155e0ca
Compare
155e0ca to
0cab058
Compare
4335987 to
8e312df
Compare
2 tasks
2d75ff9 to
4432e3e
Compare
Introduces 'agent_execution_mode' and 'agent_pool_id' fields to the registry module test_config schema, supporting both agent and remote execution modes. Adds validation to prevent agent_pool_id from being set when execution mode is 'remote', updates create, update, and read logic, and provides comprehensive acceptance tests for new behaviors. Also updates dependencies to latest versions.
6a6f579 to
6dc67ae
Compare
ctrombley
approved these changes
Oct 8, 2025
Collaborator
ctrombley
left a comment
There was a problem hiding this comment.
Looks great, thank you @hashimoon!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces 'agent_execution_mode' and 'agent_pool_id' fields to the registry module test_config schema, supporting both agent and remote execution modes. Adds validation to prevent agent_pool_id from being set when execution mode is 'remote', updates create, update, and read logic, and provides comprehensive acceptance tests for new behaviors. Also updates dependencies to latest versions.
Remember to:
Testing plan
- Apply the first Terraform config above
- Verify in TFE/TFC UI that the module's test configuration shows agent execution mode
- Verify the specified agent pool is being used
- Start with a module using remote execution
- Update the configuration to use agent execution mode with an agent pool
- Run terraform apply and verify the change is applied successfully
- Start with a module using agent execution mode
- Change agent_execution_mode back to "remote" and remove agent_pool_id
- Verify the module reverts to remote execution
- Attempt to set agent_pool_id without setting agent_execution_mode = "agent"
- Verify that Terraform returns the appropriate validation error
External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.
Rollback Plan
Changes to Security Controls