Audit Token's expiry is now computed from API if null#1991
Draft
sana-faraz wants to merge 1 commit intomainfrom
Draft
Audit Token's expiry is now computed from API if null#1991sana-faraz wants to merge 1 commit intomainfrom
sana-faraz wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a user provides an empty expiry_at for an audit trail token previously it would be set to null in the state file.
Now, owing to the new TTL restrictions the default expired_at is 2 yrs which is what is returned from the backend.
This causes discrepancy between what is planned(null) and what is applied(2yrs).
Remember to:
Testing plan
External links