Skip to content

Conversation

@jbardin
Copy link
Member

@jbardin jbardin commented Nov 27, 2024

manual backport of #36118


While the evaluator can deal with unknown template variables, if the entire map of variables is unknown, we can't create the map and need to short-circuit the call.

Fixes #36110

While the evaluator can deal with unknown template variables, if the
entire map of variables is unknown, we can't create the map and need to
short-circuit the call.
@jbardin jbardin requested a review from a team November 27, 2024 18:13
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbardin jbardin merged commit 399dc27 into v1.10 Nov 27, 2024
4 checks passed
@jbardin jbardin deleted the jbardin/backport-36118 branch November 27, 2024 19:14
@github-actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants