-
Notifications
You must be signed in to change notification settings - Fork 9.9k
Add testing helpers that allow comparing diagnostics, refactor existing tests to use them. #36456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
74c2680
to
4f670a5
Compare
4f670a5
to
2635a30
Compare
2635a30
to
1d8c86b
Compare
SarahFrench
commented
Feb 12, 2025
DanielMSchmidt
previously approved these changes
Feb 12, 2025
👆🏻 Had a merge conflict |
dsa0x
approved these changes
Feb 19, 2025
DanielMSchmidt
approved these changes
Feb 19, 2025
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces testing helpers for comparing diagnostics in the tfdiags package.
Summary:
terraform
package -assertDiagnosticsMatch
- that I've replaced in this PR.cmp.Diff(want, got, DiagnosticComparer)
with the helper that does that internallyOpen questions:
There are some other test helpers that can be moved into tfdiags/testing.go, but I'll save that for subsequent PRs due to the large number of diffs that refactoring causes.
Target Release
N/A
CHANGELOG entry