stacks: pre-destroy refresh should use a normal plan #36696
Merged
+248
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamcervante
added
the
no-changelog-needed
liamcervante
force-pushed
the
liamcervante/stacks/refresh-with-normal-plan
branch
from
93c2c68 to
9df9077
Compare
dsa0x
previously approved these changes
Mar 14, 2025
…te/stacks/refresh-with-normal-plan
dsa0x
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular Terraform actually uses a normal plan for the pre-destroy refresh: https://github.com/hashicorp/terraform/blob/main/internal/terraform/context_plan.go#L491.
This PR updates Stacks to do the same, this fixes a bug where a partially destroyed state could error because modules cannot be validated due to missing resources. This actually improves the accuracy of many outputs for destroy plans so is a positive on that front as well.