Config-driven importing through identity (TF-23179) #36703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanck
force-pushed
the
dbanck/import-via-identity
branch
from
e6c5f49 to
0252e5a
Compare
dbanck
force-pushed
the
dbanck/import-via-identity
branch
from
b6f8033 to
cc694a7
Compare
dbanck
added
the
no-changelog-needed
dbanck
force-pushed
the
dbanck/import-via-identity
branch
from
cc694a7 to
92ffcdd
Compare
dbanck
commented
Mar 20, 2025
| if importTarget.Type().IsObjectType() { | ||
| h.println(fmt.Sprintf( | ||
| h.view.colorize.Color("[reset][bold]%s: Preparing import... [identity=%s]"), | ||
| id.Addr, importTarget.GoString(), // TODO improve |
There was a problem hiding this comment.
Has Terraform a helper method somewhere to nicely display a cty.Object?
dbanck
force-pushed
the
dbanck/import-via-identity
branch
from
92ffcdd to
1dbb40e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for importing resources via their identity
Target Release
1.12.x
CHANGELOG entry
I'm planning to add changelog entries for the whole feature in a separate PR