-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: optional backend s3 skip kms key id validation #36730
Open
lucioreisgh
wants to merge
7
commits into
hashicorp:main
Choose a base branch
from
lucioreisgh:f/optional-backend-s3-skip-kms-key-id-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat: optional backend s3 skip kms key id validation #36730
lucioreisgh
wants to merge
7
commits into
hashicorp:main
from
lucioreisgh:f/optional-backend-s3-skip-kms-key-id-validation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucio Reis <[email protected]>
Signed-off-by: Lucio Reis <[email protected]>
Signed-off-by: Lucio Reis <[email protected]>
This PR relates to #34763 |
Thanks for this submission! It will be up to the HashiCorp AWS provider team to review this PR. Backends typically are not a high priority for review but I have let them know. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
skip_kms_key_id_validation
Option to S3 BackendThis PR adds the option
skip_kms_key_id_validation
to the S3 backend.Skipping the validation allows usage of KMS key IDs that trigger errors due to the regex.
Target Release
1.12.x
CHANGELOG entry