Skip to content

Allow cleanup of states that depend on prior runs outputs #36902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: f-controlling-destroys
Choose a base branch
from
Open

Allow cleanup of states that depend on prior runs outputs #36902

wants to merge 1 commit into from
+60 −22

Conversation

dsa0x
Copy link
Member

@dsa0x dsa0x commented Apr 17, 2025

Fixes #

Target Release

1.13.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@dsa0x dsa0x force-pushed the sams/cmd-test-cleanup branch 2 times, most recently from f45f122 to d9adf58 Compare April 17, 2025 12:20
@dsa0x dsa0x added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Apr 17, 2025
@dsa0x dsa0x marked this pull request as ready for review April 17, 2025 12:20
@dsa0x dsa0x requested a review from a team as a code owner April 17, 2025 12:20
@dsa0x dsa0x force-pushed the sams/cmd-test-cleanup branch from d9adf58 to 9c6189e Compare April 18, 2025 07:10
liamcervante
liamcervante reviewed Apr 22, 2025
View reviewed changes
Copy link
Member

@liamcervante liamcervante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also want to update the normal cleanup operation as well right? If a run block fails to get destroyed, any dependent run blocks that have different state should not be destroyed as we might need the outputs from that state file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamcervante liamcervante liamcervante left review comments

Assignees
No one assigned
Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsa0x @liamcervante