Backport of Relax resource identity validation into v1.12 #36991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…e with provider setting
* ./scripts/changelog.sh nextminor This turns main into 1.13 dev branch * update PR template
Non-comparable diagnostics were being adding multiple times, which might also panic in the equality comparison
…ibutes to null (#36824) * write-only attributes: internal providers should set write-only attributes to null * add changelog * fix copywrite headers
Extra values can be any type, and are only asserted by interface by the party expecting that interface so we can't attempt to compare them for equality. The only diagnostic type with Extra values which implements Equals is and hcl diagnostic.
The source check was skipped if either value was nil, but we can't be sure they are equal if there is no value. This may prove to be problematic is tests, as diagnostic equality for deduplication isn't strict equality, but rather relies on being able to prove the context is also equal.
fix issues with diagnostic deduplication
Fix non-user facing bugs where appended diags are not returned in `terraform` provider
…36787) * stacks: allow removed blocks to target components in nested stacks * make copywrite fix * fix comments
backend/oss: Supports more standard environment variables to keep same with provider setting
…36814) * stacks: update removed blocks to allow targeting of embedded stacks * copywrite headers
Removing typo per #36859.
Fix for #36859 in mocking.mdx
Highlighted the syntax example (//) next to the plain-text "A special double-slash syntax" for better visibility
remove bucket name from s3:prefix condition in IAM policy
Replace sc with Set-Content
…col (#36878) * grpcwrap+provider-simple: Test ephemeral resource schemas in v5 protocol * Update internal/command/e2etest/providers_schema_test.go Co-authored-by: Daniel Banck <[email protected]> --------- Co-authored-by: Daniel Banck <[email protected]>
…is invoked (#36852) * Fix defects where `done` is called before the command's `Run` method is invoked We're attempting to reading output from a command that hasn't been executed yet! * Another one
* stacks: improve test coverage for removed blocks * remove leftover comment
* stacks: removed blocks should refresh during refresh plans * fix copywrite headers * clarify return values of DefinedByStackInstance
* Validate identity to match identity schema * validate on new create too and add tests * validate schema nesting type * validate required attrs * remove need for extra fn --------- Co-authored-by: Samsondeen Dare <[email protected]>
Update iframe to VideoEmbed
* Add changelog entries for resource identities * Remove changelog
…een-statemigrate-and-command
…temigrate-and-command Break dependency of stack migrate on command Meta to prevent import cycles
|
Closed in favor of #36992 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #36989 to be assessed for backporting due to the inclusion of the label 1.12-backport.
The below text is copied from the body of the original PR.
This PR removes two resource identity validations:
Target Release
1.12.x
CHANGELOG entry
Overview of commits
e57a4f7
76b4a64