add extra origin information for deprecation diagnostics #38052
+761
−362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
added
the
no-changelog-needed
DanielMSchmidt
force-pushed
the
deprecation-diagnostics-extra-origin
branch
3 times, most recently
from
6e72b27 to
a12e649
Compare
DanielMSchmidt
force-pushed
the
deprecation-diagnostics-extra-origin
branch
from
fbfd15f to
ca88f6f
Compare
jbardin
reviewed
Jan 14, 2026
Member
jbardin
left a comment
jbardin
left a comment
There was a problem hiding this comment.
Something we need to be careful of is that UnmarkDeep is a very expensive operation, so it needs to be kept out of any hot paths in Terraform. I'm not seeing anything concerning yet after removing the recursive validation in count/for_each, but I can take a closer look on the other PRs too.
DanielMSchmidt
force-pushed
the
deprecation-diagnostics-extra-origin
branch
7 times, most recently
from
e7bf756 to
1becc84
Compare
This was referenced Jan 20, 2026
DanielMSchmidt
force-pushed
the
deprecation-diagnostics-extra-origin
branch
from
1becc84 to
1f5c492
Compare
DanielMSchmidt
force-pushed
the
deprecations-in-variables-and-outputs
branch
from
daa048d to
710afaa
Compare
DanielMSchmidt
force-pushed
the
deprecation-diagnostics-extra-origin
branch
2 times, most recently
from
a52acd5 to
63e51e0
Compare
DanielMSchmidt
force-pushed
the
deprecations-in-variables-and-outputs
branch
from
710afaa to
fed3ea9
Compare
DanielMSchmidt
force-pushed
the
deprecation-diagnostics-extra-origin
branch
from
63e51e0 to
de0d028
Compare
DanielMSchmidt
force-pushed
the
deprecations-in-variables-and-outputs
branch
from
fed3ea9 to
a9cb1c9
Compare
DanielMSchmidt
force-pushed
the
deprecation-diagnostics-extra-origin
branch
4 times, most recently
from
4f969c4 to
3f705da
Compare
12 tasks
DanielMSchmidt
force-pushed
the
deprecations-in-variables-and-outputs
branch
from
a9cb1c9 to
f877341
Compare
DanielMSchmidt
force-pushed
the
deprecation-diagnostics-extra-origin
branch
from
3f705da to
5f40540
Compare
DanielMSchmidt
force-pushed
the
deprecations-in-variables-and-outputs
branch
from
f877341 to
d79bf08
Compare
We want to be able to give better information if e.g. the entire module is stored in a local and the deprecated value is only later used. Where the diag is emitted we might only see the local and not the true origin of the deprecation A string identifying the source of the deprecation should help
…rtain locations Mainly terminal locations for the value where they are used, such as the config of a resource, for_each, outputs. We don't want to evaluate the deprecation deeply when it comes to values where the value is not yet used, e.g. locals This is because if e.g. a deeply nested value is deprecated it should still be ok for the entire object to be in a local whereas the same object should give a warning in e.g. an output
DanielMSchmidt
force-pushed
the
deprecation-diagnostics-extra-origin
branch
from
5f40540 to
f2387a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #38001
Attaches and displays extra information on diagnostics about the origin of deprecated values.
Fixes #
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry