deprecation: limit deep unmarking for better performance #38082
+148
−158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
added
the
no-changelog-needed
Contributor
|
The equivalence tests failed. Please investigate here. |
DanielMSchmidt
force-pushed
the
limit-usage-of-deep-unmarking-2
branch
2 times, most recently
from
f84a4ce to
6afd3af
Compare
DanielMSchmidt
force-pushed
the
use-deprecation-marks-for-resource-deprecation-3
branch
from
bda61b0 to
280e593
Compare
DanielMSchmidt
force-pushed
the
limit-usage-of-deep-unmarking-2
branch
from
6afd3af to
de41238
Compare
DanielMSchmidt
force-pushed
the
use-deprecation-marks-for-resource-deprecation-3
branch
from
280e593 to
f5e79eb
Compare
DanielMSchmidt
force-pushed
the
limit-usage-of-deep-unmarking-2
branch
from
de41238 to
bdc972e
Compare
DanielMSchmidt
force-pushed
the
use-deprecation-marks-for-resource-deprecation-3
branch
from
f5e79eb to
7e3ae80
Compare
DanielMSchmidt
force-pushed
the
limit-usage-of-deep-unmarking-2
branch
5 times, most recently
from
d00ce77 to
efac832
Compare
12 tasks
DanielMSchmidt
force-pushed
the
use-deprecation-marks-for-resource-deprecation-3
branch
from
7e3ae80 to
ced2884
Compare
DanielMSchmidt
force-pushed
the
limit-usage-of-deep-unmarking-2
branch
from
9a3ecfc to
9ca210c
Compare
DanielMSchmidt
force-pushed
the
use-deprecation-marks-for-resource-deprecation-3
branch
from
ced2884 to
1ae68b1
Compare
DanielMSchmidt
force-pushed
the
limit-usage-of-deep-unmarking-2
branch
from
9ca210c to
1afde6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #38077
Unmarking deep is an expensive operation that we want to circumvent if possible. This PR tinkers with the API so that less unmarking is necessary.
Fixes #
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry