test: Enable assertions about prompt text shown to users#38212
Merged
SarahFrench merged 3 commits intomainfrom Feb 26, 2026
Merged
test: Enable assertions about prompt text shown to users#38212SarahFrench merged 3 commits intomainfrom
SarahFrench merged 3 commits intomainfrom
Conversation
…sertions about what prompts a user has been shown. Make cleanup happen inside the helper.
…s to `testInputMap` can be used
radeksimko
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The
testInputMapallows engineers to define a list of responses to be returned to prompts with matching Ids. When used in the context of a test this Input method would return values early based on the contents oftestInputResponseMap.This PR
This PR is part of breaking down #38205. In that PR we're implementing a security feature that prompts users to review downloaded providers. This includes presenting the user with hash data, so testing that feature should include making some assertions about the prompts users see.
In this PR I update the
testInputMaphelper to return a buffer containing the prompt text that a user would see, which can optionally be used for assertions in tests. To enable filling that buffer with the prompt text I have moved the point infunc (i *UIInput) InputwheretestInputResponseMapis used to below where the prompt is written to the input io.Writer.I've updated a test showing how this can be used.
Also, I've updated the
testInputMaphelper to queue cleanup internally, so calling code doesn't need to handle the returnedclosefunction.Target Release
N/A
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry