Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When connected to HCPTF/TFE, terraform-svchost performs some service discovery request, at least two during terraform init. Troublingly, terraform-svchost only attempts one request for each discovery, so any network or service failure can cause CLI errors before plan or apply begins. We've noticed that the vast majoring of these requests succeed in < 100ms, but at scale, many requests per day can hang for various reasons, including temporary internet connection problems or just basic service availability during transition states.
terraform-svchost v0.2.1 adds retryablehttp, attempting the discovery request up to 4 times (3 retries) with a 5 second timeout.
In practical terms, service discovery will time out after 20 seconds if there is no header response from 4 requests, whereas previously it would time out after 11 seconds if there was no header response from 1 request.
Target Release
1.15.0
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry