communicator/ssh: redact certificate authentication errors - #38949
Closed
maithilijoshi20 wants to merge 2 commits into
Closed
communicator/ssh: redact certificate authentication errors#38949maithilijoshi20 wants to merge 2 commits into
maithilijoshi20 wants to merge 2 commits into
Conversation
Contributor
|
Hi, thanks for the submission. As this bypassed the normally required process as outlined in https://github.com/hashicorp/terraform/blob/main/.github/CONTRIBUTING.md, particularly Proposing a change and potentially AI Usage, I am going to close this pull request. I'd suggest first, in the issue, establishing if the maintainers are open to reviewing a change in this area and then following the guidelines in Contributing.md. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SSH certificate authentication errors include private-key or certificate material in terminal and CI logs.
Change
Return the underlying SSH parsing and signer errors without formatting credential values into the error message. Add a 1.17 changelog entry for the user-visible security fix.
Tests
Target Release
1.17.x
Rollback Plan
Revert this PR to restore the previous error-message formatting.
Changes to Security Controls
SSH authentication errors no longer include private key or certificate material in terminal and CI logs.
Fixes #38577